Closed Bug 1526405 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 15173 - Test that the HTMLPortalElement/activate promise is rejected if detached.

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15173 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15173
Details from upstream follow.

Jeremy Roman <jbroman@chromium.org> wrote:

Test that the HTMLPortalElement/activate promise is rejected if detached.

The simplest way to achieve this is to just make a portal and try to
activate it straight away.

This code was previously unreachable in our tests:
https://analysis.chromium.org/p/chromium/coverage/file?host=chromium.googlesource.com&project=chromium/src&ref=refs/heads/master&revision=f3878c07b1c5501e27ea0964d8a0ba0196cf7680&path=//third_party/blink/renderer/core/html/portal/html_portal_element.cc

Bug: 916310
Change-Id: I20cc6cbfb242e5466df6ffbbe0e30c065d6806ee
Reviewed-on: https://chromium-review.googlesource.com/c/1447030
Reviewed-by: Adithya Srinivasan \<adithyas@chromium.org>
Commit-Queue: Jeremy Roman \<jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627932}

Ran 1 tests and 1 subtests
OK     : 1
FAIL   : 1

New tests that have failures or other problems:
/portals/portals-activate-no-browsing-context.html
    A portal with nothing in it cannot be activated: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db8d4d86141b
[wpt PR 15173] - Test that the HTMLPortalElement/activate promise is rejected if detached., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/22dec3239fde
[wpt PR 15173] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.