1526447 - Remove NS_STYLE_GRID_REPEAT macro definitions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Sakshi mathur]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Convert NS_STYLE_GRID_REPEAT to enum class

Since there is only a single occurrence of this, I converted it there.

Actual results:

Currently using NS_STYLE_GRID_REPEAT macro definitions.

Expected results:

Changed this to enum class StyleGridRepeat.

Comment 1

[Boris Chiou [:boris]]

Change this to enum class is ok to me, but it seems no one use this on the gecko side. I guess we forgot to remove NS_STYLE_GRID_REPEAT after introducing stylo. IMO, it'd be better to remove them for now.

Comment 2

[Boris Chiou [:boris]]

OK, mats added this in gecko css parser and use this enum for serialization. All of them had been moved to servo side. It should be fine to remove this macro.

Comment 3

[singuliere]

I would like to work on this bug.

Comment 4

[singuliere]

Attachment: Bug 1526447 - remove unused NS_STYLE_GRID_REPEAT_* macros

Remove unused NS_STYLE_GRID_REPEAT_* macro definitions.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a59737bc6d81
remove unused NS_STYLE_GRID_REPEAT_* macros r=boris

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a59737bc6d81

Comment 7

[singuliere]

Thanks for the quick turnaround :-)