Closed Bug 1526447 Opened 11 months ago Closed 5 months ago

Remove NS_STYLE_GRID_REPEAT macro definitions

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: sakshijodhpur, Assigned: singuliere)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Convert NS_STYLE_GRID_REPEAT to enum class

Since there is only a single occurrence of this, I converted it there.

Actual results:

Currently using NS_STYLE_GRID_REPEAT macro definitions.

Expected results:

Changed this to enum class StyleGridRepeat.

Blocks: 1277133

Change this to enum class is ok to me, but it seems no one use this on the gecko side. I guess we forgot to remove NS_STYLE_GRID_REPEAT after introducing stylo. IMO, it'd be better to remove them for now.

OK, mats added this in gecko css parser and use this enum for serialization. All of them had been moved to servo side. It should be fine to remove this macro.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
Summary: Change NS_STYLE_GRID_REPEAT macro definitions to scoped enum class StyleGridRepeat → Remove NS_STYLE_GRID_REPEAT macro definitions
Priority: P4 → P3

I would like to work on this bug.

Flags: needinfo?(boris.chiou)

Remove unused NS_STYLE_GRID_REPEAT_* macro definitions.

Assignee: nobody → singuliere
Flags: needinfo?(boris.chiou)
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a59737bc6d81
remove unused NS_STYLE_GRID_REPEAT_* macros r=boris
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Thanks for the quick turnaround :-)

You need to log in before you can comment on or make changes to this bug.