1526451 - Disable Unboxed Objects

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

This is a pref-flip after Bug 1525579.

The plan here would be to land the disable pref, and ensure there's no large fallout, and decide on how to handle any regressions that come in as a result of this.

The worst case scenario is that sufficiently large regressions require us to re-enable the pref.

Here's the evidence in favour of landing this pref-flip

• Talos results here indicate no significant changes from flipping the pref.

• Bug 1505574, Comment 5 discusses tests on an earlier version of this patch against real-world websites, and showed a geomean increase in performance.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1526451 - Disable unboxed objects by default r?jandem,tcampbell

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

(PS: I would appreciate some help in figuring out who we need consensus from to ship this. I tagged Jan and Ted on review, but that doesn't necessarily mean I am right)

Comment 3

[Jan de Mooij [:jandem]]

Performance sheriffs: this will likely regress/improve some benchmarks. We're very interested in the data though.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c4f5992c89e
Disable unboxed objects by default r=jandem,tcampbell

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4c4f5992c89e