Closed Bug 1526451 Opened 5 years ago Closed 5 years ago

Disable Unboxed Objects

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

References

Details

Attachments

(1 file)

This is a pref-flip after Bug 1525579.

The plan here would be to land the disable pref, and ensure there's no large fallout, and decide on how to handle any regressions that come in as a result of this.

The worst case scenario is that sufficiently large regressions require us to re-enable the pref.

Here's the evidence in favour of landing this pref-flip

  • Talos results here indicate no significant changes from flipping the pref.

  • Bug 1505574, Comment 5 discusses tests on an earlier version of this patch against real-world websites, and showed a geomean increase in performance.

(PS: I would appreciate some help in figuring out who we need consensus from to ship this. I tagged Jan and Ted on review, but that doesn't necessarily mean I am right)

Performance sheriffs: this will likely regress/improve some benchmarks. We're very interested in the data though.

Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c4f5992c89e
Disable unboxed objects by default r=jandem,tcampbell
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → mgaudet
Depends on: 1527820
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: