1526473 - Please export NSS_CMSSignedData_GetDigestAlgs and NSS_CMSSignedData_HasDigests in security/nss.symbols

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement)

Description

[Kai Engert [:KaiE:]]

Thunderbird needs NSS_CMSSignedData_GetDigestAlgs, could we please add it to nss.symbols?

Comment 1

[Kai Engert [:KaiE:]]

We also need NSS_CMSSignedData_HasDigests

Comment 2

[Kai Engert [:KaiE:]]

Attachment: 1526473-v1.patch

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 9042620 [details] [diff] [review]
1526473-v1.patch

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

No code change. No functionality change.

String changes made/needed

Comment 4

[Jorg K (CEST = GMT+2)]

(Maybe a good idea to preview comments so they don't turn out so big and bold as above)

Comment 5

[Kai Engert [:KaiE:]]

Jörg, that bold comment was automatically created when I requested approval-beta. That opened a form inside bugzilla. I didn't tell anything to make it bold :)

Comment 6

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9042620 [details] [diff] [review]
1526473-v1.patch

Review of attachment 9042620 [details] [diff] [review]:
-----------------------------------------------------------------

I am pleased to see that these methods check their input pointers. :)

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9042620 [details] [diff] [review]
1526473-v1.patch

Should not affect Firefox, and will be useful for Thunderbird; discussed over email.
OK for beta uplift.

Comment 8

[Jorg K (CEST = GMT+2)]

Who's going to land this? The patch doesn't have a HG header, otherwise I'd set "checkin needed".

Comment 9

[Kai Engert [:KaiE:]]

I'm checking it in.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e14d77dce8c
Export NSS_CMSSignedData_GetDigestAlgs and NSS_CMSSignedData_HasDigests in security/nss.symbols, r=jcj

Comment 11

[Kai Engert [:KaiE:]]

landed into beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/d3f91dc5dfb47a91357c8276074fe57090bc5466

Comment 12

[Kai Engert [:KaiE:]]

Oh, I remember I must keep the bug open, and let pulsebot close it when landed into mozilla-central.

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6e14d77dce8c

Comment 14

[Frank-Rainer Grahl (:frg)]

Will this be uplifted to esr60? Bug 1507218 broke SeaMonkey 2.57 linking. If not I will need to do the confvars.sh patch in suite.

Comment 15

[Kai Engert [:KaiE:]]

I don't expect this to be uplifted to esr60, if necessary, we'll probably use the confvars approach.

Comment 16

[Jorg K (CEST = GMT+2)]

Sorry, FRG, please use the confvars trick.

Comment 17

[mac198442]

(In reply to Jorg K (GMT+1) from comment #16)

Sorry, FRG, please use the confvars trick.

I thought we were trying to get rid of confvars tricks! :-(