Please export NSS_CMSSignedData_GetDigestAlgs and NSS_CMSSignedData_HasDigests in security/nss.symbols

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox66 fixed, firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago

Thunderbird needs NSS_CMSSignedData_GetDigestAlgs, could we please add it to nss.symbols?

(Assignee)

Comment 1

3 months ago

We also need NSS_CMSSignedData_HasDigests

Summary: Please export NSS_CMSSignedData_GetDigestAlgs in security/nss.symbols → Please export NSS_CMSSignedData_GetDigestAlgs and NSS_CMSSignedData_HasDigests in security/nss.symbols
(Assignee)

Comment 2

3 months ago
Assignee: nobody → kaie
Attachment #9042620 - Flags: review?(jjones)
(Assignee)

Updated

3 months ago
Attachment #9042620 - Flags: review?(dkeeler)
(Assignee)

Comment 3

3 months ago

Comment on attachment 9042620 [details] [diff] [review]
1526473-v1.patch

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

No code change. No functionality change.

String changes made/needed

Attachment #9042620 - Flags: approval-mozilla-beta?

Comment 4

3 months ago

(Maybe a good idea to preview comments so they don't turn out so big and bold as above)

(Assignee)

Comment 5

3 months ago

Jörg, that bold comment was automatically created when I requested approval-beta. That opened a form inside bugzilla. I didn't tell anything to make it bold :)

Comment on attachment 9042620 [details] [diff] [review]
1526473-v1.patch

Review of attachment 9042620 [details] [diff] [review]:
-----------------------------------------------------------------

I am pleased to see that these methods check their input pointers. :)
Attachment #9042620 - Flags: review?(jjones) → review+
(Assignee)

Updated

3 months ago
Attachment #9042620 - Flags: review?(dkeeler)
Comment on attachment 9042620 [details] [diff] [review]
1526473-v1.patch

Should not affect Firefox, and will be useful for Thunderbird; discussed over email.
OK for beta uplift.
Attachment #9042620 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 8

3 months ago

Who's going to land this? The patch doesn't have a HG header, otherwise I'd set "checkin needed".

(Assignee)

Comment 9

3 months ago

I'm checking it in.

Comment 10

3 months ago
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e14d77dce8c
Export NSS_CMSSignedData_GetDigestAlgs and NSS_CMSSignedData_HasDigests in security/nss.symbols, r=jcj
(Assignee)

Comment 11

3 months ago
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
(Assignee)

Updated

3 months ago
(Assignee)

Comment 12

3 months ago

Oh, I remember I must keep the bug open, and let pulsebot close it when landed into mozilla-central.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 13

3 months ago
bugherder
Status: REOPENED → RESOLVED
Last Resolved: 3 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Will this be uplifted to esr60? Bug 1507218 broke SeaMonkey 2.57 linking. If not I will need to do the confvars.sh patch in suite.

Flags: needinfo?(kaie)
(Assignee)

Comment 15

3 months ago

I don't expect this to be uplifted to esr60, if necessary, we'll probably use the confvars approach.

Flags: needinfo?(kaie)

Comment 16

3 months ago

Sorry, FRG, please use the confvars trick.

Comment 17

3 months ago

(In reply to Jorg K (GMT+1) from comment #16)

Sorry, FRG, please use the confvars trick.

I thought we were trying to get rid of confvars tricks! :-(

You need to log in before you can comment on or make changes to this bug.