1526489 - Move AutoApplyAsyncTestAttributes into AsyncPanZoomController method implementations

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Botond Ballo [:botond]]

We have an RAII helper class named AutoApplyAsyncTestAttributes that's used to implement reftest-async-scroll and reftest-async-zoom by temporarily applying the specified async scroll and zoom in relevant places.

Currently, placing this class on the stack is the responsibility of the callers of AsyncPanZoomController methods that query async transforms, such as AsyncCompositionManager.

Such call sites have been proliferating with the containerless scrolling work (bug 1459312), and they're starting to feel a bit repetitive.

In this bug I'd like to explore moving the usage of this class inside the relevant AsyncPanZoomController methods themselves.

I have a vague recollection of Kashav trying this when he introduced AutoApplyAsyncTestAttributes and it not working, but I don't remember why, and in any case things my have changed and a fresh look doesn't hurt.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1526489 - Remove boolean return value of {Apply,Unapply}AsyncTestAttributes. r=kats

No one was using them.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1526489 - Make AutoApplyAsyncTestAttributes reentrant. r=kats

This gives us more flexibility in where to use it, so we don't have to
worry about double application.

Depends on D24610

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1526489 - Move usage of AutoApplyAsyncTestAttributes inside AsyncPanZoomController methods. r=kats

Depends on D24611

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1526489 - Move AutoApplyAsyncTestAttributes into AsyncPanZoomController.cpp. r=kats

Now that it's an implementation detail of AsyncPanZoomController, it doesn't
need to live in APZUtils.h.

Depends on D24612

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc4ed5c152c0
Remove boolean return value of {Apply,Unapply}AsyncTestAttributes. r=kats
https://hg.mozilla.org/integration/autoland/rev/d3071cbcf678
Make AutoApplyAsyncTestAttributes reentrant. r=kats
https://hg.mozilla.org/integration/autoland/rev/967a5709c655
Move usage of AutoApplyAsyncTestAttributes inside AsyncPanZoomController methods. r=kats
https://hg.mozilla.org/integration/autoland/rev/d94e429f5760
Move AutoApplyAsyncTestAttributes into AsyncPanZoomController.cpp. r=kats

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/cc4ed5c152c0
https://hg.mozilla.org/mozilla-central/rev/d3071cbcf678
https://hg.mozilla.org/mozilla-central/rev/967a5709c655
https://hg.mozilla.org/mozilla-central/rev/d94e429f5760