Closed Bug 1526511 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15146 - Allow audio requests in getDisplayMedia() calls from blink

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15146 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15146
Details from upstream follow.

Emircan Uysaler <emircan@chromium.org> wrote:

Allow audio requests in getDisplayMedia() calls from blink

This CL adds cases to allow for getDisplayMedia({video:true, audio:true}) calls.

  • Remove the earlier checks in blink that adds exceptions for audio requests.
  • Reject audio-only requests.
  • Set up UserMediaRequest appropriately and allow for settings in
    MediaStreamManager.
  • Add a FakeUI case to create a dummy AudioDevice.
  • Add unit tests and layout tests.

Bug: 896333
Change-Id: I627c8ce84d752528430c4d46c0c5f472b39706d1
Reviewed-on: https://chromium-review.googlesource.com/c/1444353
Reviewed-by: Guido Urdaneta \<guidou@chromium.org>
Commit-Queue: Emircan Uysaler \<emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628366}

Ran 1 tests and 31 subtests
OK     : 1
PASS   : 29
FAIL   : 2

New tests that have failures or other problems:
/screen-capture/getdisplaymedia.https.html
    getDisplayMedia({"audio":true}) must fail with TypeError: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bb3a759197e
[wpt PR 15146] - Allow audio requests in getDisplayMedia() calls from blink, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4bb3a759197e

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.