Closed Bug 1526532 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 14937 - Add RTCError, RTCErrorInit, RTCErrorDetailType and WPT coverage.

Categories

(Core :: WebRTC, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14937 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14937
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:

Add RTCError, RTCErrorInit, RTCErrorDetailType and WPT coverage.

This allows us to construct the RTCError. Changing error types thrown
by various methods will be done in separate CLs.

Intent to Implement & Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TsJA1XX7mTE

Bug: 821806
Change-Id: I876bb1b7859e69018ba970b528e515313b068c39
Reviewed-on: https://chromium-review.googlesource.com/c/1421797
Commit-Queue: Henrik Boström \<hbos@chromium.org>
Reviewed-by: Philip Jägenstedt \<foolip@chromium.org>
Reviewed-by: Marina Ciocea \<marinaciocea@chromium.org>
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628585}

Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 1 tests and 22 subtests OK : 1 FAIL : 22 New tests that have failures or other problems: /webrtc/RTCError.html RTCError constructor throws TypeError if any argument is missing: FAIL RTCError constructor throws TypeError if the errorDetail is invalid: FAIL RTCError constructor with message and errorDetail: FAIL RTCError.code is 0: FAIL RTCError.errorDetail is readonly.: FAIL RTCError.httpRequestStatusCode is null by default: FAIL RTCError.httpRequestStatusCode is readonly: FAIL RTCError.httpRequestStatusCode is settable by constructor: FAIL RTCError.name is 'RTCError': FAIL RTCError.receivedAlert is null by default: FAIL RTCError.receivedAlert is readonly: FAIL RTCError.receivedAlert is settable by constructor: FAIL RTCError.sctpCauseCode is null by default: FAIL RTCError.sctpCauseCode is readonly: FAIL RTCError.sctpCauseCode is settable by constructor: FAIL RTCError.sdpLineNumber is null by default: FAIL RTCError.sdpLineNumber is readonly: FAIL RTCError.sdpLineNumber is settable by constructor: FAIL RTCError.sentAlert is null by default: FAIL RTCError.sentAlert is readonly: FAIL RTCError.sentAlert is settable by constructor: FAIL RTCErrorInit.errorDetail is the only required attribute: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3e77e99c9ea1 [wpt PR 14937] - Add RTCError, RTCErrorInit, RTCErrorDetailType and WPT coverage., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/dd8ec58bb04d [wpt PR 14937] - Update wpt metadata, a=testonly
See Also: → 1527916
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.