Closed Bug 1526551 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15206 - Add custom timeout to EventWatcher to get better failures on wpt test.

Categories

(Core :: CSS Transitions and Animations, enhancement, P4)

Product:
Core
Component:
CSS Transitions and Animations
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15206 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15206
Details from upstream follow.

Robert Flack <flackr@chromium.org> wrote:

Add custom timeout to EventWatcher to get better failures on wpt test.

Currently if any test in event-dispatch.tentative.html fails, the entire
suite fails with a timeout in run_web_tests, and upstream in WPT all
subsequent tests fail. This patch adds a two requestAnimationFrame
timeout for each of the event watcher wait_for calls for the transition
events test suite by which time the events should have been received.

This allows us to get finer grained test pass/failure results for this
test suite if any particular test is missing events.

Bug: 926233
Change-Id: Ie0c9260f8eacc7f89bf42c90060b5cdb562433f0
Reviewed-on: https://chromium-review.googlesource.com/c/1450039
Commit-Queue: Robert Flack \<flackr@chromium.org>
Reviewed-by: Stephen McGruer \<smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628734}

Component: web-platform-tests → CSS Transitions and Animations
Product: Testing → Core
Ran 1 tests and 26 subtests
OK     : 1
PASS   : 26
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d0973185f57
[wpt PR 15206] - Add custom timeout to EventWatcher to get better failures on wpt test., a=testonly

https://hg.mozilla.org/mozilla-central/rev/5d0973185f57

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.