1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

This is no longer since the shapes highlighter is already shipped.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da1dd1b03268
Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out 1 changesets (Bug 1526591) for ES lint failure in | /builds/worker/checkouts/gecko/devtools/client/shared/output-parser.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=227618186

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227618186&repo=mozilla-inbound&lineNumber=268

[vcs 2019-02-11T13:17:34.396Z]
[vcs 2019-02-11T13:17:34.396Z] 270910 files updated, 0 files merged, 0 files removed, 0 files unresolved
[vcs 2019-02-11T13:17:34.656Z] updated to da1dd1b03268eb90be06b1418fbf23957bd5ce1b
[vcs 2019-02-11T13:17:34.659Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "clone", "shouldAlert": false, "subtests": [], "value": 150.93808484077454}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "update", "shouldAlert": false, "subtests": [], "value": 85.69211292266846}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall", "shouldAlert": false, "subtests": [], "value": 236.9481270313263}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall_clone", "shouldAlert": false, "subtests": [], "value": 236.9481270313263}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall_clone_fullcheckout", "shouldAlert": false, "subtests": [], "value": 236.9481270313263}]}
[vcs 2019-02-11T13:17:34.937Z] TinderboxPrint:<a href=https://hg.mozilla.org/integration/mozilla-inbound/rev/da1dd1b03268eb90be06b1418fbf23957bd5ce1b title='Built from mozilla-inbound revision da1dd1b03268eb90be06b1418fbf23957bd5ce1b'>da1dd1b03268eb90be06b1418fbf23957bd5ce1b</a>
[task 2019-02-11T13:17:34.937Z] executing ['bash', '-cx', 'cd /builds/worker/checkouts/gecko/ && cp -r /build/node_modules_eslint node_modules && ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules && ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules && ./mach lint -l eslint -f treeherder --quiet\n']
[task 2019-02-11T13:17:34.940Z] + cd /builds/worker/checkouts/gecko/
[task 2019-02-11T13:17:34.940Z] + cp -r /build/node_modules_eslint node_modules
[task 2019-02-11T13:17:35.200Z] + ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules
[task 2019-02-11T13:17:35.201Z] + ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules
[task 2019-02-11T13:17:35.201Z] + ./mach lint -l eslint -f treeherder --quiet
[task 2019-02-11T13:17:35.989Z] New python executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python2.7
[task 2019-02-11T13:17:35.989Z] Also creating executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python
[task 2019-02-11T13:17:37.755Z] Installing setuptools, pip, wheel...done.
[task 2019-02-11T13:17:38.842Z] running build_ext
[task 2019-02-11T13:17:38.842Z] building 'psutil._psutil_linux' extension
[task 2019-02-11T13:17:38.842Z] creating build
[task 2019-02-11T13:17:38.842Z] creating build/temp.linux-x86_64-2.7
[task 2019-02-11T13:17:38.842Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2019-02-11T13:17:38.842Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-02-11T13:17:38.842Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-02-11T13:17:38.842Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2019-02-11T13:17:38.842Z] creating build/lib.linux-x86_64-2.7
[task 2019-02-11T13:17:38.842Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2019-02-11T13:17:38.842Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2019-02-11T13:17:38.842Z] building 'psutil._psutil_posix' extension
[task 2019-02-11T13:17:38.842Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-02-11T13:17:38.842Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-02-11T13:17:38.842Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-02-11T13:17:38.842Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-02-11T13:17:38.842Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-02-11T13:17:38.842Z]
[task 2019-02-11T13:17:38.842Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-02-11T13:23:27.429Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/shared/output-parser.js:7:7 | 'Services' is assigned a value but never used. (no-unused-vars)
[taskcluster 2019-02-11 13:23:27.745Z] === Task Finished ===
[taskcluster 2019-02-11 13:23:27.745Z] Unsuccessful task run with exit code: 1 completed in 623.938 seconds

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30bd96c2f467
Backed out 1 changesets for ES lint failure in | /builds/worker/checkouts/gecko/devtools/client/shared/output-parser.js CLOSED TREE

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Fixed eslint error and relanded.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05888c293d3e
Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/05888c293d3e