1526597 - Canonization should be applied to all result types, and the input's value should reflect the canonized URL

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

See bug 1521702 comment 4 and later. All result types should be able to be canonized, not only search and autofill results.

Also see https://phabricator.services.mozilla.com/D18620#inline-100752 The value that pickResult passes to setValueFromResult should be the canonized value, not the value in the result. It might be better to fix that part in a separate bug, not sure, but I'm guessing not since it's closely related to the first part.

Comment 1

[Marco Bonardo [:mak]]

I wonder if this should block nightly, the architectural changes here touch a quite central part of the load behavior and going through QA without it makes me a bit nervous... thoughts?

Comment 2

[Marco Bonardo [:mak]]

I'm moving it to nightly for now, because the involved risk, we can re-evaluate obviously.

Comment 3

[Drew Willcoxon :adw]

Seems right. I'll work on this unless someone else has already started on it (I haven't).

Comment 4

[Dão Gottwald [:dao]]

Attachment: half-baked WIP patch

I started looking into this yesterday but things got a bit messy...

Comment 5

[Drew Willcoxon :adw]

All right, feel free to take this then.

Comment 6

[Dão Gottwald [:dao]]

Yeah, I can try to fix up that patch.

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1526597 - Canonization should be applied to all result types, and the input's value should reflect the canonized URL. r=mak

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e049c2537d4
Canonization should be applied to all result types, and the input's value should reflect the canonized URL. r=mak

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2e049c2537d4

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2e049c2537d4