1526624 - Fix Xray waivers to deal with multiple globals per compartment

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Right now XrayWaiver (note: not XrayWaiverWrapper) wrappers are same-compartment and same-realm with their target. The latter is relied on to have them act with the target's principals.

In the multiple-realms-per-compartment world, we could make them same-realm with the target, but that involves a bit of nasty work on FixWaiverAfterTransplant. Or we can just allow them to be same-compartment but not same-realm (due to transplants), and enter the target's realm before calling on to it. Bobby prefers the latter option.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1526624. Fix Xray waivers to deal with multiple globals per compartment. r=bholley

In the new setup, they are still same-compartment with their target, but may
not be same-realm (due to transplants).

We could make them be same-realm by adjusting FixWaiverAfterTransplant, but
this is conceptually simpler.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c7ae3e0b592
Fix Xray waivers to deal with multiple globals per compartment. r=bholley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c37ccc879d7
followup.  Fix clang-format issues in WrapperFactory.  r=me

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6c7ae3e0b592
https://hg.mozilla.org/mozilla-central/rev/4c37ccc879d7