Closed Bug 1526643 Opened 7 years ago Closed 6 years ago

[wpt-sync] Sync PR 15129 - Fix remaining preload tests flaking on wpt.fyi

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15129 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15129
Details from upstream follow.

Kunihiko Sakamoto <ksakamoto@chromium.org> wrote:

Fix remaining preload tests flaking on wpt.fyi

This is a follow-up to https://github.com/web-platform-tests/wpt/pull/15075.

https://crrev.com/c/1436777 successfully fixed the wpt.fyi flakiness
for link-header-preload-srcset.tentative.html and
link-header-preload-nonce.html. This patch fixes that for the remaining
preload tests.

  • Use step_timeout instead of dummy.js?pipe=trickle, because
    dummy.js?pipe=trickle may be loaded from cache with no delay.
  • Replace verifyNumberOfDownloads() with
    • verifyNumberOfResourceTimingEntries() if possible
    • A new helper function verifyLoadedAndNoDoubleDownload() that
      doesn't fail if the resource was already cached before running
      the test.

Bug: 922343
Change-Id: Ia9b7c4bd49dd76463df4607349fe4f935e5410d0
Reviewed-on: https://chromium-review.googlesource.com/c/1442020
Reviewed-by: Kinuko Yasuda \<kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto \<ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629029}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 19 tests and 19 subtests OK : 18 PASS : 13 FAIL : 6 Tests that are disabled for instability: /preload/link-header-preload-delay-onload.html
Component: DOM: Core & HTML → web-platform-tests
Product: Core → Testing
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/31c2d8270ec1 [wpt PR 15129] - Fix remaining preload tests flaking on wpt.fyi, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b67c6a2fd48 [wpt PR 15129] - Fix remaining preload tests flaking on wpt.fyi, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8b67c6a2fd48

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.