[wpt-sync] Sync PR 15270 - Relax required SNR a bit

RESOLVED FIXED in Firefox 67

Status

()

Product:
Core
Component:
Web Audio
Type:
enhancement
Importance:
P4
normal
Status:
RESOLVED FIXED
Reported:
3 months ago
Modified:
2 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

Version:
unspecified
Target:
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream],
URL
)

Assignee

Description

•
3 months ago

Sync web-platform-tests PR 15270 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15270
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Relax required SNR a bit

The required SNR was a little too high for some Mac OS bots. Make it
a little smaller.

Bug: 929435
Change-Id: I5fbfe6573f4907f33999085e52bb22f4b4b9a126
Reviewed-on: https://chromium-review.googlesource.com/1457228
WPT-Export-Revision: aaf571cb98e4bd884c993490624f60ca76dc5e6b
Assignee

Comment 1

•
3 months ago 
PR 15270 applied with additional changes from upstream: 5a6917c5cb8ea8602c53fd927fe3c208bb99b463
 Assignee

Updated

•
3 months ago
Component: web-platform-tests → Web Audio
Product: Testing → Core
 Assignee

Comment 5

•
3 months ago 
Ran 1 tests and 12 subtests
OK     : 1
PASS   : 6
FAIL   : 6

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html
    # AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed.: FAIL
    < [buffer-stitching-1] 2 out of 3 assertions were failed.: FAIL
    < [buffer-stitching-2] 1 out of 3 assertions were failed.: FAIL
    X SNR (56.56582705421649 dB) is not greater than or equal to 65.737. Got 56.56582705421649.: FAIL
    X SNR (58.62182031202294 dB) is not greater than or equal to 85.58. Got 58.62182031202294.: FAIL
    X Stitched sine-wave buffers at sample rate 44100 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732956767082214,0.4248766303062439,0.4807544946670532,0.5347436666488647,0.5866319537162781,0.6362155675888062,0.683299720287323,0.7276993989944458,0.7692402005195618,0.8077588677406311...] with an element-wise tolerance of {"absoluteThreshold":0.000090957,"relativeThreshold":0}.
	Index	Actual			Expected		AbsError		RelError		Test threshold
	[2003]	-9.6732087433338165e-2	-9.6823699772357941e-2	9.1612339019775391e-5	9.4617680624852212e-4	9.0957000000000003e-5
	[2004]	-3.4187544137239456e-2	-3.4279607236385345e-2	9.2063099145889282e-5	2.6856520995424621e-3	9.0957000000000003e-5
	[2005]	2.8491314500570297e-2	2.8398986905813217e-2	9.2327594757080078e-5	3.2510876202481997e-3	9.0957000000000003e-5
	[2006]	9.1058239340782166e-2	9.0966261923313141e-2	9.1977417469024658e-5	1.0111157205356415e-3	9.0957000000000003e-5
	[2007]	1.5326742827892303e-1	1.5317615866661072e-1	9.1269612312316895e-5	5.9584737668585898e-4	9.0957000000000003e-5
	...and 38045 more errors.
	Max AbsError of 2.0274701528251171e-3 at index of 44050.
	[44050]	-7.1237324737012386e-3	-5.0962623208761215e-3	2.0274701528251171e-3	3.9783473164634225e-1	9.0957000000000003e-5
	Max RelError of 5.5714977262789269e+1 at index of 30419.
	[30419]	-1.4247581129893661e-3	-2.5121373255387880e-5	1.3996367397339782e-3	5.5714977262789269e+1	9.0957000000000003e-5
: FAIL

Comment 6

•
2 months ago 
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/feaa22c216e3
[wpt PR 15270] - Relax required SNR a bit, a=testonly

Comment 7

•
2 months ago 
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f990f5b15536
[wpt PR 15270] - Relax required SNR a bit, a=testonly

Comment 8

•
2 months ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f990f5b15536

Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.