Closed
Bug 1526657
Opened 6 years ago
Closed 6 years ago
Python 3 "AttributeError: 'dict' object has no attribute 'iteritems'"
Categories
(Tree Management :: Treeherder, enhancement, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
Running our Python tests under Python 3 there are a number of:
> return {k: v for k, v in all_fields.iteritems() if k in keys}
E AttributeError: 'dict' object has no attribute 'iteritems'
treeherder/services/elasticsearch/utils.py:56: AttributeError
(eg https://travis-ci.org/mozilla/treeherder/jobs/490927271#L670)
Whilst all usages of iteritems were previously switched to use six (in https://github.com/mozilla/treeherder/commit/5d6cb2371c7f9c4bfccc388b540bddef2fa0cbda), it looks like this was regressed in:
https://github.com/mozilla/treeherder/commit/7563231facb1a9a221aa97c82198673275b7edce#diff-991e530663a94bd8b61dca24d193a4caR56
|
||
Comment 1•6 years ago
|
||
|
Assignee | |
Comment 2•6 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•