1526793 - Clearing "Always use private browsing" flag in the preferences doesn't force a restart (via modal alert dialog box)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[:Gijs (he/him)]

[Tracking Requested - why for this release]:

See https://bugzilla.mozilla.org/show_bug.cgi?id=1524995#c2

Beta is also affected, and this could potentially leave users (and in-product code) confused about whether they're in private browsing mode or not.

Comment 1

[:Gijs (he/him)]

STR:

1. clean profile
2. open about:preferences#privacy
3. switch to 'use custom settings for history'
4. turn on 'Always use Private Browsing Mode'
5. accept the dialog to restart
6. once restarted, reopen about:preferences#privacy
7. turn off 'Always use Private Browsing Mode'

ER:
same dialog

AR:
no dialog.

Regression window:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=33ca2ea6b37064d12c0d4fefc81bf689396a5e57&tochange=9ae7ae0acee4f8807cffaf64fef4f2e3a614b997

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1526793 - always prompt for restart when toggling permanent private browsing mode, r?jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a84cc180ca9
always prompt for restart when toggling permanent private browsing mode, r=jaws

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2a84cc180ca9

Comment 5

[:Gijs (he/him)]

Comment on attachment 9042838 [details]
Bug 1526793 - always prompt for restart when toggling permanent private browsing mode, r?jaws

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1518252

User impact if declined

This could potentially leave users (and in-product code) confused about whether they're in private browsing mode or not.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

See comment #1

List of other uplifts needed

n/a

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Simple small fix to only the relevant JS so low chance of unintended consequences, comes with automated test to verify it works correctly now

String changes made/needed

n/a

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

I have managed to reproduce the issue using Fx 67.0a1 buildID: 20190204092937.

The issue is verified fixed using latest Fx 67.0a1 (buildID: 20190212195904) on macOS 10.14, Ubuntu 16.04 and Windows 10. After unchecking the "Always use private browsing mode" the user receives the prompt to restart the browser.

Comment 7

[:Gijs (he/him)]

This hasn't been uplifted to beta yet... and beta is definitely affected.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9042838 [details]
Bug 1526793 - always prompt for restart when toggling permanent private browsing mode, r?jaws

Fix for confusing state of prefs in PB mode.
Verified in Nightly. OK for uplift for beta 8.

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f47db91d62e1

Comment 10

[Cristian Baica [:cbaica], Release Desktop QA]

Coming back with a confirmation for Fx66.0b8 on macOS 10.14, Windows 10 and Ubuntu 18.04. The user is now correctly prompted to restart the browser. This can't be bypassed now by refreshing the page.