Closed Bug 1526824 Opened 4 years ago Closed 4 years ago

Remove "src" attribute from menuitem XBL and styles ("image" attribute is always used instead)

Categories

(Toolkit :: XUL Widgets, task, P3)

Product:
Toolkit
Component:
XUL Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

Bug 1526824 - Remove "src" attribute handling from menuitem XBL and styles;
47 bytes, text/x-phabricator-request
Details | Review

In addition to inheriting "src=image" there is a direct inheritance of "src" from the host element: https://searchfox.org/mozilla-central/search?q=%2Csrc%22&path=

But AFAICT this is never used, the [image] attribute is used instead:

This appears to be unused, and the [image] attribute on the host is inherited onto
.menu-iconic-icon[src] as an alternative.

Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a686eb70ac01
Remove "src" attribute handling from menuitem XBL and styles; r=NeilDeakin

https://hg.mozilla.org/mozilla-central/rev/a686eb70ac01

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.