1526824 - Remove "src" attribute from menuitem XBL and styles ("image" attribute is always used instead)

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Brian Grinstead [:bgrins]]

In addition to inheriting "src=image" there is a direct inheritance of "src" from the host element: https://searchfox.org/mozilla-central/search?q=%2Csrc%22&path=

But AFAICT this is never used, the [image] attribute is used instead:

• https://searchfox.org/mozilla-central/search?q=menuitem.*src&case=false&regexp=true&path=
• https://searchfox.org/mozilla-central/search?q=menuitem.*image&case=false&regexp=true&path=

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1526824 - Remove "src" attribute handling from menuitem XBL and styles;

This appears to be unused, and the [image] attribute on the host is inherited onto
.menu-iconic-icon[src] as an alternative.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a686eb70ac01
Remove "src" attribute handling from menuitem XBL and styles; r=NeilDeakin

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a686eb70ac01