1526952 - please create a `data-review` flag

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task, P1)

Description

[:glob ✱]

please create a data-review flag.

it needs to be bound to the same set of components as the firefox review flag.

the flag setters should be a new group called "Data Stewards".

chutten: can you provide a list of users who need to be able to set/clear the data-review flag?

Comment 1

[Chris H-C :chutten]

Everyone needs to be able to set the flag to ?. Data Review is a developer-driven workflow.

If we're wanting to limit who can set it to + or , I suppose the list of Data Stewards should be the only ones setting it. The current list of Data Stewards can be found here and are, as of this writing:

Chenxia Liu (:liuche) - Mobile frontend
:chutten - Firefox Telemetry
Rob Rayborn :rrayborn- Experiments
Kenny Long - Pocket
Max Weiner - Pocket
Janice Tsai - Emerging Technology
Nevin Chen - Firefox Lite

The Process owner is Rebecca Weiss, so maybe she should be included as well. Marshall Erwin and Alicia Gray are often brought in for tougher questions of Legal and Trust, so they'd be decent additions as well.

...or we could just let it be anyone and trust that the honour system and publishing the name of the data reviewer will be enough to keep people on the proper path? It'd be easier than trying to remember to keep a BMO flag list up-to-date as we add/remove Stewards.

ni?rweiss for if we should limit flag setters/clearers.

Comment 2

[Chris H-C :chutten]

We discussed this as the Data Stewards meeting and we're all in favour of it acting like the existing review flag without a specific privileged group.

Is that good, glob?

Comment 3

[:glob ✱]

sounds good to me; thanks.

Comment 4

[David Lawrence [:dkl]]

Ok. data-review flag created with some product/component visibility as the Firefox review flag. Also it is not enforced currently by any groups. Let me know if there are any changes needed.

Comment 5

[Chris H-C :chutten]

When will we see this deployed? Will it be an instantaneous cut-over at the end of the month?

(I need to coordinate when to update the documentation and start the education drive)

Comment 6

[David Lawrence [:dkl]]

(In reply to Chris H-C :chutten from comment #5)

When will we see this deployed? Will it be an instantaneous cut-over at the end of the month?

(I need to coordinate when to update the documentation and start the education drive)

The flag is available now. Go to any product which we have enabled it, create an attachment (or view an existing one) and the data-review flag should be there and can be set. No code change or deployment was needed.

dkl

Comment 7

[Chris H-C :chutten]

Attachment: image.png

Must be something on my end, then, as my flags for https://bugzilla.mozilla.org/attachment.cgi?bugid=1522657&action=enter don't have data-review. Will I have to logout/in? I've tried a force-reload.

Comment 8

[David Lawrence [:dkl]]

(In reply to Chris H-C :chutten from comment #7)

Created attachment 9044278 [details]
image.png

Must be something on my end, then, as my flags for https://bugzilla.mozilla.org/attachment.cgi?bugid=1522657&action=enter don't have data-review. Will I have to logout/in? I've tried a force-reload.

Ah I see. I didnt have Toolkit product enabled for the data-review flag as I copied the product list from the firefox review flag which doesn't have Toolkit listed. I have now added that product to data-review. Currently we have:

Cloud Services
DevTools
Firefox
Toolkit

Can you think of any products we would want the flag to be visible for?

dkl

Comment 9

[Chris H-C :chutten]

looks up the list of products

Geez, it would be basically every one of them that isn't defunct. I've personally done data reviews for everything from the build system to Firefox to ... what product does hg.mozilla.org fall under? Can't recall where that one was.

Going through the list, there are a lot that either have or I can imagine seeing Data Collection Reviews in:
AMO, AirMo, BMO (not sure what BMO's data collection practices are, come to think of it), Cloud Services, Context Graph, Core, Data*, Developer Infra, Developer Services, Fenix, Firefox* (minus Firefox Friends. Never heard of it), GeckoView, Infra & Ops, L20n, Localization Infra & Tools, mozilla.org, maybe NSS, Other Applications, Participation Infra, Pocket, Releng, probably not Seamonkey, shield, snippets, soccoro, sumo, Taskcluster (maybe), Thunderbird (I do remember an email thread about Telemetry in Thunderbird), Toolkit, User Research (though they probably have their own review), Web Extensions, Websites, maybe Webtools, www.mozilla.org

...would it be easier to make it instance-wide?

Comment 10

[David Lawrence [:dkl]]

(In reply to Chris H-C :chutten from comment #9)

looks up the list of products

Geez, it would be basically every one of them that isn't defunct. I've personally done data reviews for everything from the build system to Firefox to ... what product does hg.mozilla.org fall under? Can't recall where that one was.

Going through the list, there are a lot that either have or I can imagine seeing Data Collection Reviews in:
AMO, AirMo, BMO (not sure what BMO's data collection practices are, come to think of it), Cloud Services, Context Graph, Core, Data*, Developer Infra, Developer Services, Fenix, Firefox* (minus Firefox Friends. Never heard of it), GeckoView, Infra & Ops, L20n, Localization Infra & Tools, mozilla.org, maybe NSS, Other Applications, Participation Infra, Pocket, Releng, probably not Seamonkey, shield, snippets, soccoro, sumo, Taskcluster (maybe), Thunderbird (I do remember an email thread about Telemetry in Thunderbird), Toolkit, User Research (though they probably have their own review), Web Extensions, Websites, maybe Webtools, www.mozilla.org

...would it be easier to make it instance-wide?

We could. needinfo is set that way. Problem is if you ever wanted to go back to a subset of products instead of all it is not trivial. But if we do not think that will ever come up then we could do it that way.

Comment 11

[Chris H-C :chutten]

That requires a degree of vision into the Data Review process with which I have not been furnished :)

I'll ask rweiss.

Comment 12

[Chris H-C :chutten]

I asked rweiss and she said we don't have a reason to limit it. Please go ahead!

(( I just started receiving my first data-review requested emails. Seamless transition. Loving it. ))

Comment 13

[David Lawrence [:dkl]]

(In reply to Chris H-C :chutten from comment #12)

I asked rweiss and she said we don't have a reason to limit it. Please go ahead!

Done