1526971 - Can't drag messages from folder/inbox to Windows desktop in TB 66 beta

Status: RESOLVED FIXED

(Core :: DOM: Serializers, defect, P2)

Description

[Jorg K (CEST = GMT+2)]

As the summary says:

Can't drag messages from folder/inbox to Windows desktop in TB 66 beta.

Still working in TB 65 beta, so that gives us an idea of the regression range since TB 66 started on 2018-12-10 (https://wiki.mozilla.org/Release_Management/Calendar). TB 67 started on 2019-01-28, so it must be somewhere in between.

Alice, can you please find the regression for us.

Comment 1

[Jorg K (CEST = GMT+2)]

Walter, did you find this in beta testing?

Comment 2

[Alice0775 White]

regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=c39f35e517ffbffb547206b9b7f6c5eede04c46b&tochange=150da20417f348570344f8f59c816bf0a09a9ecc
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=619d084f08917d63aab65a8a42f1c4b40d909542&tochange=4b3fc8b9128035c63821078328c73fbc525d1950

suspect:
2e4c5ef41c73 Tom Schuster — Bug 571074 - Mark nsITransferable.getTransferData as [must_use]. r=mats

Comment 3

[WaltS48 [:walts48]]

(In reply to Jorg K (GMT+1) from comment #1)

Walter, did you find this in beta testing?

Works with TB 65.0b4 on Windows 10.
Doesn't work with TB 66.0b1 on Windows 10.
Works with TB 66.0b1 on Linux Mint 19.

Dragging and dropping messages to the desktop isn't a normal part of the test procedure, or my work flow.

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks, Alice, I'll look into it.

Walter, this should 100% be part of the test suite. Many users, including myself, export messages by dragging them onto an OS folder.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1526971-GetDownloadDetails.patch

Looks like the error checking is unwanted here.

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 9043162 [details] [diff] [review]
1526971-GetDownloadDetails.patch

Seems reasonable to me, since we'll take the else-branch and try using 'sourceURI' instead.

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: Bug 1526971 - Revert over-zealous error checking in nsDataObj::GetDownloadDetails() from bug 571074.

Comment 8

[Jorg K (CEST = GMT+2)]

First go at doing something in Phab. Looks like on can just upload a patch, as per:
00:55:50 - BenB: rjl, Phab -> Code Reviews -> (top right) Create diff
00:55:54 - BenB: https://phabricator.services.mozilla.com/differential/diff/create/

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks, Mats. Could you stick it onto the Phab version as well, so I can land it myself?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf40d50fa8af
Revert over-zealous error checking in nsDataObj::GetDownloadDetails() from bug 571074. r=mats

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bf40d50fa8af

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 9043162 [details] [diff] [review]
1526971-GetDownloadDetails.patch

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 571074

User impact if declined

Not sure for Firefox, but for Thunderbird, users can't export messages via drag&drop on Windows any more.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Not risky. It only reverts one hunk of bug 571074 to the original state, hence a "mini backout".

String changes made/needed

None.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9043162 [details] [diff] [review]
1526971-GetDownloadDetails.patch

Partial backout, should help Thunderbird.
Doesn't seem risky for Firefox since it is reverting to previous behavior.
OK for uplift for beta 10.

Comment 15

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b328a01648c