Closed
Bug 152700
Opened 22 years ago
Closed 22 years ago
compiler warnings caused by 119380 checkin
Categories
(Directory :: LDAP XPCOM SDK, defect)
Directory
LDAP XPCOM SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
timeless
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
ayn2 wrote:
> This checking have added two "might be used uninitialized" warnings:
>
> +directory/xpcom/base/src/nsLDAPBERValue.cpp:59
> + `PRUint8 * array' might be used uninitialized in this function
> +
> +directory/xpcom/base/src/nsLDAPMessage.cpp:600
> + `nsresult rv' might be used uninitialized in this function
It turns out that the first warning even uncovered a bug, though a completely
trivial one. I've switched to gcc 3.1 so I'll start seeing these warnings also.
Patch forthcoming.
|
Assignee | |
Comment 1•22 years ago
|
||
|
||
Comment 2•22 years ago
|
||
Bug 59652 tracks "may be used uninitialized" warnings.
BTW, brad TBox shows all these warnings.
Blocks: 59652
Attachment #88215 -
Flags: review+
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•22 years ago
|
Attachment #88215 -
Flags: superreview?(bryner)
|
||
Updated•22 years ago
|
Attachment #88215 -
Flags: superreview?(bryner) → superreview+
|
|
||
Comment 3•22 years ago
|
||
*** Bug 188124 has been marked as a duplicate of this bug. ***
|
|
||
Comment 4•22 years ago
|
||
The first warning was fixed in bug 191717, the second is still there:
directory/xpcom/base/src/nsLDAPMessage.cpp:588
`nsresult rv' might be used uninitialized in this function
|
|
||
Comment 5•22 years ago
|
||
timeless checked in the patch.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•