artifact build for win10/aarch64 fails
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: egao, Assigned: gbrown)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.74 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
A non-artifact build can be executed and completes as expected: example
However if the --artifact value is passed, such as ./mach try fuzzy --query "windows10-aarch64/opt --artifact, the build fails with the following error:
Whoops!
You are trying to pass a shortname for --custom-build-variant-cfg.
However, I need to know the bits to find the appropriate filename. You can tell me by passing:
"--bits" or a config filename via "--config" with "32" or "64" in it.
In either case, these option arguments must come before --custom-build-variant.
|
Reporter | |
Updated•7 years ago
|
|
Assignee | |
Comment 1•7 years ago
|
||
I know a little about artifact builds and can have a look. I notice that there seems to be no win/aarch64 allowance in https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/python/mozbuild/mozbuild/artifacts.py, for instance. Has anyone tried to make this work before? Any known blockers?
|
||
Comment 2•7 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #1)
I know a little about artifact builds and can have a look. I notice that there seems to be no win/aarch64 allowance in https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/python/mozbuild/mozbuild/artifacts.py, for instance. Has anyone tried to make this work before? Any known blockers?
There's no real reason we shouldn't do this; we just have to do all the artifact-alternative verbiage. Bug 1525069 suggests we want to support this; no reason to not do so in automation.
|
|
Assignee | |
Comment 3•7 years ago
|
||
Making some progress:
|
|
Assignee | |
Comment 4•7 years ago
|
||
Oddly, I have had trouble with opt artifact builds:
I have finally sorted out that the issue is that the build system cannot determine if win64-aarch64/opt is a 32 or 64 bit build, whereas for win64/opt, win64/debug, and win64-aarch64/debug, those are identified as 64 bit by having "64" in config file names such as:
https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/taskcluster/ci/build/windows.yml#1077
https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/taskcluster/ci/build/windows.yml#127
https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/taskcluster/ci/build/windows.yml#228
vs:
|
|
Assignee | |
Comment 5•7 years ago
|
||
|
|
||
Comment 6•7 years ago
|
||
|
|
Assignee | |
Comment 7•7 years ago
|
||
(In reply to Nick Alexander :nalexander [he/him] from comment #6)
::: browser/config/mozconfigs/win64-aarch64/artifact
@@ +1,3 @@+. "$topsrcdir/build/mozconfig.artifact.automation"
+
+# Needed to set SourceRepository in application.ini (used by Talos)This might be true, but it's more that
MOZILLA_OFFICIALis the "we're
building in Mozilla's automation" flag, and should be true for every build
in TC.
It's not my wording: copied from (for instance) https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/browser/config/mozconfigs/win64/artifact#3
I'll keep it, for consistency.
|
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
Description
•