1527044 - [wpt-sync] Sync PR 15133 - Deflake RTCPeerConnection-track-stats.https.html.

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15133 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15133
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

Deflake RTCPeerConnection-track-stats.https.html.

This CL does the following:

1. Add a test that verifies we have a succeeded candidate pair in
   getStats() as soon as iceConnectionState is "connected". This is
   currently flaky (https://crbug.com/926170) and marked as such.
2. Add workaround to RTCPeerConnection-track-stats.https.html so that
   it does not flake due to 1), and mark it not flaky.
3. Move shared helper functions to RTCPeerConnection-helper.js.
4. Add test coverage for making sure we can become connected in the
   recvonly use case. This requires changing the prefix to
   ".https.html" of "RTCPeerConnection-iceConnectionState".

// Already reviewed by [e-mail]
TBR=[e-mail]

Bug: 922955, 926170
Change-Id: I828e46273a84447c817595a466a5e143bde30eca
Reviewed-on: https://chromium-review.googlesource.com/c/1442201
Reviewed-by: Henrik Boström \<[e-mail]>
Commit-Queue: Henrik Boström \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#627421}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0bb3cc5694be85ab8063230d87c71bbf6caa9ab

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6094de3c5fb627c78dcfac70565ca09d085d8b4f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 62 tests and 778 subtests
OK     : 50
PASS   : 436
FAIL   : 320
TIMEOUT: 13
NOTRUN : 15

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/webrtc/RTCPeerConnection-track-stats.https.html: TIMEOUT
    RTCPeerConnection.getStats(receivingTrack) is the same as RTCRtpReceiver.getStats(): NOTRUN
    RTCPeerConnection.getStats(sendingTrack) is the same as RTCRtpSender.getStats(): NOTRUN
    RTCPeerConnection.getStats(track) throws InvalidAccessError when there are multiple senders for the track: NOTRUN
    RTCPeerConnection.getStats(track) throws InvalidAccessError when there are zero senders or receivers for the track: NOTRUN
    RTCRtpReceiver.getStats() contains only inbound-rtp and related stats: NOTRUN
    RTCRtpSender.getStats() contains only outbound-rtp and related stats: TIMEOUT

New tests that have failures or other problems:
/webrtc/RTCIceConnectionState-candidate-pair.https.html: TIMEOUT
    On ICE connected, getStats() contains a connected candidate-pair: TIMEOUT
/webrtc/RTCPeerConnection-iceConnectionState.https.html
    connection with one data channel should eventually have connected connection state: FAIL

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html
/webrtc/RTCPeerConnection-onnegotiationneeded.html
/webrtc/RTCPeerConnection-setRemoteDescription-answer.html
/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
/webrtc/RTCPeerConnection-transceivers.https.html
/webrtc/RTCRtpTransceiver.https.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9e8c0189449
[wpt PR 15133] - Deflake RTCPeerConnection-track-stats.https.html., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6fa4f764ee3
[wpt PR 15133] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e80d7b6fe064
[wpt PR 15133] - Deflake RTCPeerConnection-track-stats.https.html., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1592f48542d
[wpt PR 15133] - Update wpt metadata, a=testonly

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e80d7b6fe064
https://hg.mozilla.org/mozilla-central/rev/f1592f48542d