1527056 - Camera/microphone onAndroidPermissionsRequest and onContentPermissionRequest are getting call in a different order than location permissions

Status: RESOLVED WONTFIX

(GeckoView :: General, defect, P2)

Description

[Arturo Mejia [:amejia]]

For permissions like: Camera and microphone first 1.onAndroidPermissionsRequest is called and then 2.onContentPermissionRequest is called, but when the location permission is requested, the order changes first 1.onContentPermissionRequest is called and after 2.onAndroidPermissionsRequest is getting called, the order should be the same as camera and microphone permissions.

I could reproduce this issue on GeckoView Sample app

Comment 1

[Chris Peterson [:cpeterson]]

P1

btw, why does a location permission request need to call onMediaPermissionRequest?

Comment 2

[Arturo Mejia [:amejia]]

Sorry Chris Peterson, my mistake I meant onContentPermissionRequest. Thanks for the observation I updated the title and description.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

I don't think the order should really matter here, and we certainly don't try to guarantee any specific order. Is there a reason you think we need to, or are you just saying that they should be consistent?

Comment 4

[Arturo Mejia [:amejia]]

I mean whichever is the order, it must be consistent across all permissions.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Arturo Mejia from comment #4)

I mean whichever is the order, it must be consistent across all permissions.

I see. I personally don't think that's important. Once an Android permission has been granted, we shouldn't prompt later unless it is revoked. For site permissions we've decided want to prompt every time, so we're already in the position where they're not called with the same frequency. Given that, I don't really see how the order matters, but I could be convinced otherwise if you have a strong reason.

Comment 6

[Arturo Mejia [:amejia]]

👍 I don't have a strong opinion about it, it really doesn't affect the behaviour, but It caught my attention as I was testing all the permission one after the other. Fennec has the same behaviour , I did the same exercise on Chrome but it has a consistent order.

Feel free to close it, if you feel to!

Comment 7

[Chris Peterson [:cpeterson]]

Andreas, do you think we can close this bug or defer it until after Fenix MVP?

Comment 8

[Andreas Bovens [:abovens]]

Reading through the thread, I seems to be mostly a matter of engineering consistency. Let's not close it, but defer it until after MVP.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Andreas Bovens [:abovens] from comment #8)

Let's not close it, but defer it until after MVP.

Sounds good. [geckoview:fenix:p3] so we revisit this bug after Fenix MVP.

Comment 10

[Chris Peterson [:cpeterson]]

I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:

e88a5094-0fc0-4b7c-b7c5-aef00a11dbc9

Comment 11

[Chris Peterson [:cpeterson]]

Arturo confirmed this is a GV bug. The Fenix issue is a P2 in Fenix's "Items waiting for Fenix Q3" bug list. I'll tag this bug as [geckoview:fenix:m9] so we review it again for Q4.

https://github.com/orgs/mozilla-mobile/projects/29#card-23269171

Comment 12

[Chris Peterson [:cpeterson]]

https://github.com/mozilla-mobile/fenix/issues/1686

Comment 13

[Chris Peterson [:cpeterson]]

This is by design. Gecko needs to show the system permission prompt first so we can get list of camera and microphones to list them in the browser's content permission prompt.

Jeff is going to discuss this behavior with Vesta and decide whether we want to change this camera/microphone prompts.

https://github.com/mozilla-mobile/fenix/issues/1686#issuecomment-548790944