1527256 - [socket process] make about:networking work

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Kershaw Chang [:kershaw]]

Currently, the SocketData is filled here [1].
When socket process is enable, we have to find a way to get the SocketData from socket process.

[1] https://searchfox.org/mozilla-central/rev/5e3bffe964110b8d1885b4236b8abd5c94d8f609/netwerk/base/Dashboard.cpp#339

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1527256 - P1: Get SocketData from socket process

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1527256 - P2: Get DNSCacheEntries from socket process

Comment 3

[BugBot [:suhaib / :marco]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:kershaw, could you have a look please?

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #3)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:kershaw, could you have a look please?

This is not going to land to mc for now.
I'll rebase this and land this to larch.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1527256 - P3: Get HttpData from socket process

Depends on D20355

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1527256 - P4: Enable about:networking tests

Depends on D82320

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a37b0cdf3155
P1: Get SocketData from socket process r=dragana
https://hg.mozilla.org/integration/autoland/rev/c15bc3e821ea
P2: Get DNSCacheEntries from socket process r=dragana
https://hg.mozilla.org/integration/autoland/rev/8172b4bbba7b
P3: Get HttpData from socket process r=dragana
https://hg.mozilla.org/integration/autoland/rev/5f3e90d1112e
P4: Enable about:networking tests r=dragana

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 4 changesets (bug 1527256) for network related bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=build&fromchange=5f3e90d1112e4225b0ca7a7569a99f560cd346dd&tochange=49ec79ba187b470f83538f620275a476287e6626&selectedTaskRun=Ww4PPzeySrubUDpLz7o3lg.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/49ec79ba187b470f83538f620275a476287e6626

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308956375&repo=autoland&lineNumber=27831

[task 2020-07-08T10:13:56.329Z] 10:13:56     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/netwerk/sctp/src'
[task 2020-07-08T10:13:56.330Z] 10:13:56     INFO -  netwerk/sctp/src/sctp_auth.obj
[task 2020-07-08T10:13:56.330Z] 10:13:56     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -Xclang -std=gnu99 -m32 -Fosctp_auth.obj -c  -Xclang -ftrivial-auto-var-init=pattern -guard:cf -DDEBUG=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DCOMPILER_MSVC -DSCTP_SIMPLE_ALLOCATOR=1 -DSCTP_PROCESS_LEVEL_LOCKS=1 -D__Userspace__=1 -DCALLBACK_API=1 -DSCTP_DEBUG=1 -D__Userspace_os_Windows=1 -D_LIB=1 -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/netwerk/sctp/src -I/builds/worker/workspace/obj-build/netwerk/sctp/src -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Qunused-arguments -Xclang -fexperimental-new-pass-manager  -Xclang -MP -Xclang -dependency-file -Xclang .deps/sctp_auth.obj.pp -Xclang -MT -Xclang sctp_auth.obj   /builds/worker/checkouts/gecko/netwerk/sctp/src/netinet/sctp_auth.c
[task 2020-07-08T10:13:56.330Z] 10:13:56     INFO -  In file included from /builds/worker/checkouts/gecko/netwerk/sctp/src/netinet/sctp_auth.c:40:
[task 2020-07-08T10:13:56.330Z] 10:13:56     INFO -  In file included from /builds/worker/checkouts/gecko/netwerk/sctp/src/netinet/sctp_os.h:74:
[task 2020-07-08T10:13:56.331Z] 10:13:56     INFO -  In file included from /builds/worker/checkouts/gecko/netwerk/sctp/src/netinet/sctp_os_userspace.h:458:
[task 2020-07-08T10:13:56.331Z] 10:13:56     INFO -  /builds/worker/checkouts/gecko/netwerk/sctp/src/user_atomic.h(81,13): warning: unused function 'atomic_init' [-Wunused-function]
[task 2020-07-08T10:13:56.331Z] 10:13:56     INFO -  static void atomic_init() {} /* empty when we are not using atomic_mtx */
[task 2020-07-08T10:13:56.331Z] 10:13:56     INFO -              ^
[task 2020-07-08T10:13:56.331Z] 10:13:56     INFO -  1 warning generated.
[task 2020-07-08T10:13:56.331Z] 10:13:56     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/sctp/src'
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/netwerk/socket'
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -Xclang -std=c++17 -m32 -FoUnified_cpp_netwerk_socket0.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -Xclang -ftrivial-auto-var-init=pattern -guard:cf -DDEBUG=1 -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/netwerk/socket -I/builds/worker/workspace/obj-build/netwerk/socket -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -Xclang -fexperimental-new-pass-manager  -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_netwerk_socket0.obj.pp -Xclang -MT -Xclang Unified_cpp_netwerk_socket0.obj   Unified_cpp_netwerk_socket0.cpp
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  In file included from Unified_cpp_netwerk_socket0.cpp:2:
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  In file included from /builds/worker/checkouts/gecko/netwerk/socket/nsNamedPipeIOLayer.cpp:22:
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  In file included from /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.h:18:
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/net/DashboardTypes.h:8:
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  /builds/worker/workspace/obj-build/dist/include/ipc/IPCMessageUtils.h(10,10): fatal error: 'base/process_util.h' file not found
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  #include "base/process_util.h"
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -           ^~~~~~~~~~~~~~~~~~~~~
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  1 error generated.
[task 2020-07-08T10:13:56.507Z] 10:13:56    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:748: Unified_cpp_netwerk_socket0.obj] Error 1
[task 2020-07-08T10:13:56.507Z] 10:13:56     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/socket'
[task 2020-07-08T10:13:56.508Z] 10:13:56    ERROR -  make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: netwerk/socket/target-objects] Error 2
[task 2020-07-08T10:13:56.508Z] 10:13:56     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 9

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34ba25a1d725f71440fd449b5d68e6662618f88a&selectedTaskRun=XH2AyiWYSSCIEXLu3UFGDw.0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/569112cc1631
P1: Get SocketData from socket process r=dragana
https://hg.mozilla.org/integration/autoland/rev/654c94aebd4f
P2: Get DNSCacheEntries from socket process r=dragana
https://hg.mozilla.org/integration/autoland/rev/5a7f2b59a6ab
P3: Get HttpData from socket process r=dragana
https://hg.mozilla.org/integration/autoland/rev/6d9a03300d52
P4: Enable about:networking tests r=dragana

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/569112cc1631
https://hg.mozilla.org/mozilla-central/rev/654c94aebd4f
https://hg.mozilla.org/mozilla-central/rev/5a7f2b59a6ab
https://hg.mozilla.org/mozilla-central/rev/6d9a03300d52