1527314 - Expand Cross-Origin-Opener-Policy tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

Bug 1521808 added some tests in toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js.

We need to expand the tests to include all permutations of the COOP header values and that "the header is honored for auxiliary browsing contexts, how it affects a top-level browsing context opened from a sandboxed iframe, whether it affects the browsing context name, etc"

Comment 1

[Valentin Gosu [:valentin] (he/him)]

In order to get the test to pass I also had to employ some hacks. Some of which might not be needed. Others might point to actual bugs.

• I wait for BrowserTestUtils.browserStopped instead of browserLoaded.
• I added a 20ms timeout after a process switch is performed.
• After waiting I use gBrowser.selectedBrowser instead of the previous browser object.

Without these I would get test timeouts on await ContentTask.spawn(... get process id ), and even sometimes I would get the processID of the previous process, indicating that maybe the ContentTask.spawn was executed in the previous browser instead.

See bug 1541389.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1527314 - Add tentative to cross-origin-opener WPT test names r=annevk

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1527314 - Add more Cross-Origin-Opener-Policy tests r=annevk

Depends on D33329

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c350d0bc1e71
Add tentative to cross-origin-opener WPT test names r=annevk
https://hg.mozilla.org/integration/autoland/rev/d833fd94e8e3
Add more Cross-Origin-Opener-Policy tests r=annevk

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17343 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c350d0bc1e71
https://hg.mozilla.org/mozilla-central/rev/d833fd94e8e3