Closed Bug 1527314 Opened 3 years ago Closed 2 years ago

Expand Cross-Origin-Opener-Policy tests

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

60 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Fission Milestone M3
Tracking Status
firefox69 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

Details

Attachments

(2 files)

Bug 1521808 added some tests in toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js.

We need to expand the tests to include all permutations of the COOP header values and that "the header is honored for auxiliary browsing contexts, how it affects a top-level browsing context opened from a sandboxed iframe, whether it affects the browsing context name, etc"

Priority: -- → P2

In order to get the test to pass I also had to employ some hacks. Some of which might not be needed. Others might point to actual bugs.

  • I wait for BrowserTestUtils.browserStopped instead of browserLoaded.
  • I added a 20ms timeout after a process switch is performed.
  • After waiting I use gBrowser.selectedBrowser instead of the previous browser object.

Without these I would get test timeouts on await ContentTask.spawn(... get process id ), and even sometimes I would get the processID of the previous process, indicating that maybe the ContentTask.spawn was executed in the previous browser instead.

See bug 1541389.

Component: DOM → DOM: Core & HTML
Fission Milestone: --- → M2
Status: NEW → ASSIGNED
Fission Milestone: M2 → M3
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c350d0bc1e71
Add tentative to cross-origin-opener WPT test names r=annevk
https://hg.mozilla.org/integration/autoland/rev/d833fd94e8e3
Add more Cross-Origin-Opener-Policy tests r=annevk
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17343 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Regressions: 1559494
You need to log in before you can comment on or make changes to this bug.