1527389 - The aliases of hidden engines shouldn't show up in the urlbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

See bug 1526983. If you type @, aliases for hidden engines show up, which probably shouldn't happen. This code controls which aliases appear: https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/toolkit/components/places/PlacesSearchAutocompleteProvider.jsm#93 There's a !engine.hidden check right above that, which should probably be extended to registering aliases too.

Comment 1

[Omkar Konaraddi]

Attachment: Bug 1527389 - The aliases of hidden engines shouldn't show up in the urlbar r=adw!

Comment 2

[Omkar Konaraddi]

Attachment: Bug 1527389 - The aliases of hidden engines shouldn't show up in the urlbar r=adw!

Comment 3

[Omkar Konaraddi]

Attachment: Bug 1527389 - The aliases of hidden engines shouldn't show up in the urlbar r=adw!

Comment 4

[Omkar Konaraddi]

Attachment: Bug 1527389 - The aliases of hidden engines shouldn't show up in the urlbar r=adw!

Comment 5

[Omkar Konaraddi]

Attachment: Bug 1527389 - The aliases of hidden engines shouldn't show up in the urlbar r=adw!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/351504c92d13
The aliases of hidden engines shouldn't show up in the urlbar r=adw

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/351504c92d13

Comment 8

[Dominik Danelski]

I can confirm that this patch works as intended on Firefox Nightly. However wouldn't it be better if instead of solely hiding removed engines, the added ones would be visible as well? In other words if @ would show all the engines from Preferences tab? That solution has been mentioned in a few of the duplicate bugs.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1526983 tracks that.