Tidy up WebRenderFallbackData

RESOLVED FIXED in Firefox 67

Status

()

RESOLVED FIXED
a month ago
a month ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a month ago

WebRenderFallbackData inherits WebRenderImageData mostly because images and blob images used to have the same API, but WebRenderImageData has some methods and state that would break if called on a fallback data.

It's tricky to know which image data method and state can be touched on fallback data instances and error prone. I have a patch to improve on this a bit.

(Assignee)

Comment 1

a month ago

This patch is an attempt to separate the two and avoid accidentally getting into an inconsistent state.
WebRenderImageData manages resources for images that are shared with webrender, while WebRenderFallbackData manages state to render content, in most case in a blob image.
if the fallback data needs to render into a TextureClient, it creates a WebRenderImageData to hold on to the shared texture, but does not inherit from it anymore.

Comment 3

a month ago
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96b6da57e237
Separate WebRenderImageData and WebRenderFallbackData. r=jrmuizel

Comment 4

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.