1527460 - switch webapp to everett

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The webapp uses python-decouple to pull in configuration values from the environment.

Antenna uses Everett. I plan to use Everett for the processor, too. Everett works just like python-decouple, but makes testing and documentation easier. We currently have no documentation for webapp configuration values. Ew.

This bug covers switching the webapp from using python-decouple to Everett.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This'll take 5 minutes. It's worth doing so we can document environment variables.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I forgot that Everett automatically uppercases variable names, so it doesn't work with "resource.boto.host" and friends.

I'll have to wait on this.

Comment 3

[Daniel Thorn [:relud]]

Attachment: [mozilla-services/socorro] bug-1527460: switch webapp to everett (#6520)

Comment 4

[Daniel Thorn [:relud]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #2)

I forgot that Everett automatically uppercases variable names, so it doesn't work with "resource.boto.host" and friends.

I'll have to wait on this.

I'm going to need clarification on whether this is still an issue, and if so where, because I'm not seeing what this is about.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Comment #2 is from way back when we used configman and it had terrible environment variable names that were lowercased and included periods. I finished up the configman removal in March 2023 in bug #1529342, so that comment is no longer relevant.

Comment 6

[Daniel Thorn [:relud]]

relud merged PR [mozilla-services/socorro]: bug-1527460: switch webapp to everett (#6520) in 7bbb65a.

Comment 7

[Daniel Thorn [:relud]]

my bad, resolved this too early, as of now the change is only merged to main, not deployed to prod.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

This deployed to prod in bug #1882847. Everything looks fine, so marking this as FIXED.