Closed Bug 1527488 Opened 5 years ago Closed 4 years ago

Improve Debugger startup times

Categories

(DevTools :: Debugger, enhancement, P2)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [debugger-mvp])

Attachments

(2 files, 4 obsolete files)

Bug 1527488 - Change debugger build to support lazy loading modules r=davidwalsh
47 bytes, text/x-phabricator-request
Details | Review
Bug 1527488 - Stop waiting for fetched content. r=davidwalsh
47 bytes, text/x-phabricator-request
Details | Review

Lazily loading modules has been shown to be a nice performance win.

remote:
remote: View your changes here:
remote: https://hg.mozilla.org/try/rev/482b326ed112520036b42bd19ff643c4c29af919
remote: https://hg.mozilla.org/try/rev/7df901461f71008caa212144e76d71d61f82e16d
remote:
remote: Follow the progress of your build on Treeherder:
remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7df901461f71008caa212144e76d71d61f82e16d
remote:
remote: It looks like this try push has talos jobs. Compare performance against a baseline revision:
remote: https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=7df901461f71008caa212144e76d71d61f82e16d
remote: recorded changegroup in replication log in 0.039s

Assignee: nobody → dwalsh
Priority: -- → P2
Blocks: dbg-perf
Blocks: dbg-node-build
No longer blocks: node-dx
No longer blocks: dbg-node-build
Blocks: dbg-node-build
Assignee: dwalsh → nobody
Summary: Load debugger modules via lazyRequireGetter → Improve Debugger startup times
Whiteboard: [debugger-mvp]

I can confirm it takes a very long time VS chrome devtools, often more then twice as long

Thanks for reporting.

The other DevTools panels do a better job of lazily loading the modules. We started a proof of concept 2 months ago, which I hope we can finish in a couple of weeks.

Assignee: nobody → jlaster
Status: NEW → ASSIGNED

moving back to planned while i wait on lazy loading

Status: ASSIGNED → UNCONFIRMED
Ever confirmed: false
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Status: ASSIGNED → NEW
Attachment #9068106 - Attachment description: Bug 1527488 - Change debugger build to support lazy loading modules r=jlast! → Bug 1527488 - Change debugger build to support lazy loading modules r=davidwalsh
Status: NEW → ASSIGNED
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e1b1b34e49e
Change debugger build to support lazy loading modules

https://hg.mozilla.org/mozilla-central/rev/2e1b1b34e49e

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Attachment #9068106 - Attachment is obsolete: true
Whiteboard: [debugger-mvp] → [debugger-mvp] keep-open
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b2489b9f469
Stop waiting for fetched content. r=davidwalsh
Attachment #9067419 - Attachment is obsolete: true
Keywords: leave-open
Whiteboard: [debugger-mvp] keep-open → [debugger-mvp]
Status: ASSIGNED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
Attachment #9070687 - Attachment is obsolete: true
Attachment #9070689 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.