Add external hooks to WR to allow integration with the Gecko profiler.

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gw, Assigned: gw)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago
No description provided.
Assignee

Updated

4 months ago
Assignee: nobody → gwatson

Comment 2

4 months ago
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc69bea83b66
Add external hooks to WR to allow integration with the Gecko profiler. r=kvark,emilio

Backed out for wrench bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cquantumrender%2Cdebug%2Cwebrender%2Cstandalone%2Cwebrender-linux-debug%2Cwr%28wrench%29&revision=bc69bea83b66eae8e56ea097898bd066f4c00820&selectedJob=228111233

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228111233&repo=autoland&lineNumber=206

Back-out link: https://hg.mozilla.org/integration/autoland/rev/93e37c529818028d26d1a0ff7ea46e6173b83c98

task 2019-02-13T06:59:10.838Z] 0:52.72 Downloading... 100.0 %
[task 2019-02-13T06:59:10.846Z] 0:52.73 Downloaded artifact to /builds/worker/.mozbuild/toolchains/7cd02e7e69ecd547-wrench-deps.tar.bz2
[task 2019-02-13T06:59:10.926Z] 0:52.81 hashed u'/builds/worker/.mozbuild/toolchains/7cd02e7e69ecd547-wrench-deps.tar.bz2' with sha256 to be 49c74ecf6fa5339ce6d3596f824b05460aaebd04d8add35512df0b9651b14804
[task 2019-02-13T06:59:11.082Z] 0:52.96 untarring "/builds/worker/workspace/rustc.tar.xz"
[task 2019-02-13T06:59:22.806Z] 1:04.69 untarring "/builds/worker/workspace/wrench-deps.tar.bz2"
[task 2019-02-13T06:59:30.252Z] + export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/builds/worker/workspace/rustc/bin
[task 2019-02-13T06:59:30.252Z] + PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/builds/worker/workspace/rustc/bin
[task 2019-02-13T06:59:30.252Z] + cd /builds/worker/checkouts/gecko/gfx/wr
[task 2019-02-13T06:59:30.252Z] + mv /builds/worker/workspace/wrench-deps/vendor /builds/worker/workspace/wrench-deps/.cargo ./
[task 2019-02-13T06:59:31.049Z] + CARGOFLAGS='--verbose --frozen'
[task 2019-02-13T06:59:31.049Z] + ci-scripts/linux-debug-tests.sh
[task 2019-02-13T06:59:31.050Z] + CARGOFLAGS='--verbose --frozen'
[task 2019-02-13T06:59:31.050Z] + pushd webrender_api
[task 2019-02-13T06:59:31.050Z] ~/checkouts/gecko/gfx/wr/webrender_api ~/checkouts/gecko/gfx/wr
[task 2019-02-13T06:59:31.050Z] + cargo test --verbose --frozen --features ipc
[task 2019-02-13T06:59:31.061Z] warning: /builds/worker/checkouts/gecko/gfx/wr/Cargo.toml: unused manifest key: patch.crates-io.serde_derive.feature
[task 2019-02-13T06:59:31.061Z] warning: /builds/worker/checkouts/gecko/gfx/wr/Cargo.toml: unused manifest key: workspace.license
[task 2019-02-13T06:59:31.201Z] error: no matching package named cstr found
[task 2019-02-13T06:59:31.201Z] location searched: registry https://github.com/rust-lang/crates.io-index
[task 2019-02-13T06:59:31.201Z] did you mean: atty, cc, cgl, ...
[task 2019-02-13T06:59:31.201Z] required by package webrender v0.59.0 (/builds/worker/checkouts/gecko/gfx/wr/webrender)
[taskcluster 2019-02-13 06:59:31.545Z] === Task Finished ===
[taskcluster 2019-02-13 06:59:31.545Z] Unsuccessful task run with exit code: 101 completed in 186.956 seconds

Flags: needinfo?(gwatson)

You need to run cargo update -p webrender in gfx/wr as well to update that Cargo.lock file, so the standalone WebRender build works.

Assignee

Comment 5

4 months ago

That unfortunately updates other dependencies too, but running cargo build in gfx/wr seems to have done the trick (the try run looks good).

Flags: needinfo?(gwatson)

Comment 6

4 months ago
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf288072dd8a
Add external hooks to WR to allow integration with the Gecko profiler. r=kvark,emilio

Comment 7

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.