Closed Bug 1527526 Opened 10 months ago Closed 10 months ago

AudioConduit is reporting RTP send statistics when it should be reporting RTP receive statistics

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- wontfix
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: ng, Assigned: ng)

References

Details

(Keywords: regression)

Attachments

(1 file)

The AudioConduit is reporting RTP send statistics instead of receive statistics. We can use the new stats interface that landed with the import of libwebrtc v64.

AudioConduit is reporting send instead of recv RTP stats

This regression was introduced in bug 1376873.

Blocks: 1376873
Keywords: regression
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/c0004cf7d1d1
AudioConduit is reporting send instead of recv RTP stats r=dminor
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Is this something that should be considered for Beta backport or can it ride the trains?

Flags: needinfo?(na-g)

Comment on attachment 9043475 [details]
Bug 1527526 - AudioConduit is reporting send instead of recv RTP stats

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1376873
  • User impact if declined: Call quality in WebRTC calls could suffer unbeknownst to the providing services.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It only changes the value statistics reported.
  • String changes made/needed:
Flags: needinfo?(na-g)
Attachment #9043475 - Flags: approval-mozilla-beta?

Comment on attachment 9043475 [details]
Bug 1527526 - AudioConduit is reporting send instead of recv RTP stats

OK for uplift to beta 12.

Attachment #9043475 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Nico, is there a way we can verify this in beta?

Flags: needinfo?(na-g)

Liz, yes it should be testable. I will work on a test procedure.

Flags: needinfo?(na-g)

(In reply to Nico Grunbaum [:ng] from comment #6)

  • Is this code covered by automated tests?: Yes
  • Needs manual test from QE?: No

Setting this as qe-verify- per comment 6.

Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.