1527526 - AudioConduit is reporting RTP send statistics when it should be reporting RTP receive statistics

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The AudioConduit is reporting RTP send statistics instead of receive statistics. We can use the new stats interface that landed with the import of libwebrtc v64.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1527526 - AudioConduit is reporting send instead of recv RTP stats

AudioConduit is reporting send instead of recv RTP stats

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This regression was introduced in bug 1376873.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0004cf7d1d1
AudioConduit is reporting send instead of recv RTP stats r=dminor

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c0004cf7d1d1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something that should be considered for Beta backport or can it ride the trains?

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 9043475 [details]
Bug 1527526 - AudioConduit is reporting send instead of recv RTP stats

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1376873
• User impact if declined: Call quality in WebRTC calls could suffer unbeknownst to the providing services.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only changes the value statistics reported.
• String changes made/needed:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9043475 [details]
Bug 1527526 - AudioConduit is reporting send instead of recv RTP stats

OK for uplift to beta 12.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Nico, is there a way we can verify this in beta?

Comment 9

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/7bd928c859a5

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Liz, yes it should be testable. I will work on a test procedure.

Comment 11

[Cornel Ionce [:noni]]

(In reply to Nico Grunbaum [:ng] from comment #6)

• Is this code covered by automated tests?: Yes
• Needs manual test from QE?: No

Setting this as qe-verify- per comment 6.