Closed Bug 1527595 Opened 5 years ago Closed 5 years ago

4.26 - 37.64% raptor-tp6 (android-hw-g5-7-0-arm7-api-16, android-hw-p2-8-0-android-aarch64, android-hw-p2-8-0-arm7-api-16, linux64, windows7-32) regression on push c27aa490f40b04838c41a93464a6691d2ef9352e (Tue Feb 12 2019)

Categories

(Core :: Web Painting, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: igoldan, Unassigned)

References

Details

(Keywords: perf, regression)

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a98671536694dfafaaaaeab6100573a4955d715d&tochange=c27aa490f40b04838c41a93464a6691d2ef9352e

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

38% raptor-tp6-yandex-firefox fcp windows7-32 opt 77.77 -> 107.04
21% raptor-tp6-bing-firefox fcp windows7-32 opt 77.50 -> 93.42
18% raptor-tp6m-google-geckoview fcp android-hw-p2-8-0-android-aarch64 opt 218.69 -> 258.08
18% raptor-tp6m-google-geckoview fcp android-hw-g5-7-0-arm7-api-16 opt 389.83 -> 459.67
13% raptor-tp6m-google-geckoview fcp android-hw-p2-8-0-arm7-api-16 opt 220.04 -> 248.12
10% raptor-tp6-sheets-firefox fcp linux64 opt 271.60 -> 297.71
9% raptor-tp6-reddit-firefox fcp windows7-32 pgo 258.52 -> 280.83
8% raptor-tp6m-youtube-geckoview fcp android-hw-g5-7-0-arm7-api-16 opt 454.19 -> 491.62
8% raptor-tp6-bing-firefox windows7-32 opt 73.27 -> 78.79
6% raptor-tp6-yandex-firefox windows7-32 opt 151.47 -> 160.85
6% raptor-tp6-yandex-firefox windows7-32 opt 150.98 -> 159.85
6% raptor-tp6-yahoo-news-firefox fcp windows7-32 pgo 234.71 -> 248.46
4% raptor-tp6-slides-firefox fcp linux64 opt 805.10 -> 840.71
4% raptor-tp6-slides-firefox fcp linux64 opt 808.75 -> 843.17

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=19325

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/Performance_sheriffing/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Component: General → Web Painting
Product: Testing → Core
Flags: needinfo?(mstange)

The regression list is still growing. comment 0 contains only the 1st alerts that showed up.

Bug 1506976 changes what FCP measures, so it will affect all tests that use FCP numbers. The patch doesn't actually make Firefox slower. So these regressions are expected.

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #1)

These are the Gecko profiles for Yandex on Windows 7 (OPT builds):

before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FXTJd5_erTdKDd-X-LIU86g%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_raptor-tp6-yandex-firefox.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FNy9IUgYBR16JFgUnP7RM0g%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_raptor-tp6-yandex-firefox.zip

Thanks for these profiles! Here are two views into them, constrained to the FCP marker:
before: https://perfht.ml/2X2mmn6
after: https://perfht.ml/2WZtUaq
These profiles show exactly what I would expect: In the "before" profile, FCP stops in the middle of a DisplayList marker, and in the "after" profile, FCP also includes the rasterization of the paint, the wait for the next vsync, and the composite.

Flags: needinfo?(mstange)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.