1527606 - [github] 'Details' link on GitHub should directly point to the task logs

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[Marco Castelluccio [:marco]]

Most of the time, when you click on the Taskcluster status link on GitHub, you want to see why a task failed, so it makes sense to go to the logs by default.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

You can see an example of this by going to one of the open PRs at https://github.com/taskcluster/taskcluster/pulls and clicking the "details" link in the checks display at the bottom.

I think that the "details" link always goes to the checks tab in the Github UI - so we can't change that. But, I think owlish has some ideas on how to improve the user experience here within Github's parameters.

Comment 2

[[:owlish] 🦉 PST]

In Checks API - I noticed Netlify has a custom Details link in the Deploy Preview checkrun. So that must be customizable.

In Statuses API - we can change the link.

If memory served, I already tried doing that, and there was some sort of problem. This is definitely something to investigate. Also, this can be done by one of our volunteer contributors - Dustin, do you think I can mentor this bug as a good-first-one?

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Mentoring sounds good -- even determining whether and how it's possible is a good task.

Comment 5

[[:owlish] 🦉 PST]

At the time of posting the status on github we don't have the link yet. We had a brilliant idea: why don't we solve this in the UI and make it show a spinner or something while the run log is not available yet. Hassan let me know what you think, would you like to tackle this? Can be good first bug too

Comment 6

[Hassan Ali (:hassan)]

Do we have the run number? If we do, then I think it shouldn't be too hard to handle this situation directly in the UI.

Comment 7

[Hassan Ali (:hassan)]

Created https://github.com/taskcluster/taskcluster/issues/2240 to solve this in the UI. After it gets merged, we would probably need to modify the status link slightly.

Comment 8

[Yarik Kurmyza [:yarik] (he/him) (UTC+1)]

Current implementation of Checks API includes links to the task itself and also the logs.
And Statuses API should be avoided