1527646 - moz-phab patch complains about uncommitted changes being present, despite evidence to the contrary

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

I've got moz-phab 1.17, and I just tried using moz-phab patch on D19162.

Here's my output:

$ moz-phab patch D19162 --apply-to here
Uncommited changes present. Please shelve them or commit before patching.

$ hg shelve
nothing changed

$ moz-phab patch D19162 --apply-to here
Uncommited changes present. Please shelve them or commit before patching.

I get the same thing if I omit the --apply-to here.

Comment 1

[:glob ✱]

looks like we need to exclude Untracked files from the is_worktree_clean check.

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Bug 1527646 - Allow to patch when unknown files are present r=glob