1527648 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.LauncherActivity.dispatchDeepLink(LauncherActivity.java)]

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-5a8522bd-0b41-4f91-9bc1-254010190204.

Seen while looking at nightly crash reports: https://bit.ly/2UYHMzX. Crashes appear to have started using Build 20190201093730.

I can reproduce this on my device by following one of the comments:

*entering firefox:// in the URL bar hard crashes Firefox

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9ee54a21a22ab5beab264bcabe3c8039a27a32e8&tochange=d58901c5036ffa06da6144f22a31479116ee0835

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.gecko.LauncherActivity.dispatchDeepLink(LauncherActivity.java:198)
	at org.mozilla.gecko.LauncherActivity.onCreate(LauncherActivity.java:64)
	at android.app.Activity.performCreate(Activity.java:7144)
	at android.app.Activity.performCreate(Activity.java:7135)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2931)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3086)
	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1816)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6718)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comment 1

[Vlad Baicu]

From the second patch that we've uplifted in beta from bug 1519418 at line 198 we are trying to replace the line separators from the uid parameters if they exist in order to correctly match it against the local persisted uid. However the uid might be null, therefore the regression.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

This was caused by bug 1519418 so will start showing up in beta 9 soon. Once you land a patch here please request uplift to beta. Thanks!

Comment 3

[Vlad Baicu]

Attachment: Bug 1527648 - Uid deeplink nullpointer check. r=JanH

Patch from bug 1519418 introduced a regression by removing line separators from
the uid parameter contained within deeplinks. However, not all deeplinks are
mandatory to contain the uid parameter.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57fbc6e58e2b
Uid deeplink nullpointer check. r=petru

Comment 5

[Vlad Baicu]

Comment on attachment 9044980 [details]
Bug 1527648 - Uid deeplink nullpointer check. r=JanH

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Patch 2 from 1519418

User impact if declined

Deeplinks which do not containt the uid parameter will cause a crash in LauncherActivity

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

*entering firefox:// in the URL bar hard crashes Firefox

List of other uplifts needed

Patch 2 from 1519418 needs to be uplifted first as this patch fixes the regression from that one.

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

We've guarded the line separator replacement with a null check.

String changes made/needed

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/57fbc6e58e2b

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9044980 [details]
Bug 1527648 - Uid deeplink nullpointer check. r=JanH

OK for beta uplift; this needs the 2nd patch from bug 1519418 uplifted first though.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fd591b31f209

Comment 9

[Levente Sacal]

I will wait until the 2nd patch is added to verify the issue and remove the qe-verify label.

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e61f6b679a94

Comment 11

[Levente Sacal]

Verified as fixed on the latest Nightly 67.0a1 (2019-02-22). No crash on Google Pixel C (Android 8.0.0)

Comment 12

[Levente Sacal]

Verified as fixed also on 66 Beta 11 and on release as well.