1527666 - Pressing back button often treated as long press

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Recently on Fennec Nightly I've had problems where simply tapping the device back button shows the history list as if I long pressed.

Comment 1

[Jan Henning [:JanH]]

Which Android version? (Although I'm not aware of any recent changes surrounding that code)

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Jan Henning [:JanH] from comment #1)

Which Android version? (Although I'm not aware of any recent changes surrounding that code)

9.0

Comment 3

[Jan Henning [:JanH]]

Maybe bug 1328538 could help here, too?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Dirty screen? I'm not seeing this on a Pixel 3.

Comment 5

[nukem2k5]

(In reply to Kevin Brosnan [:kbrosnan] from comment #4)

Dirty screen? I'm not seeing this on a Pixel 3.

Pixel 3 here and I'm having this same issue

Comment 7

[Jan Henning [:JanH]]

[Tracking Requested - why for this release]:

Based on the info in bug 1534918, this might have been an unwanted side effect of bug 1518225.

Can we please get back button handling finally looked at by somebody who can also properly test this on a variety of devices?

As this issue sounds potentially rather annoying, as a temporary stopgap we could push back the target API change by one release and back out bug 1518225 from 67 for Beta and Release.

Comment 8

[Pascal Chevrel:pascalc]

Stefan, could you weigh in on Jan's proposal in comment #7 from a product and roadmap perspective please? Thanks

Comment 9

[Jan Henning [:JanH]]

[...] who can also properly test this on a variety of devices

And at least with an emulator and a current local build, personally I unfortunately don't see anything strange.

Comment 10

[Sorina Florean [:sflorean]]

I was able to reproduce this issue with Google Pixel (Android Q) on the latest Nightly build.

Comment 11

[Marcia Knous [:marcia]]

Discussed during triage today. We haven't received many reports of this being an issue, but some of us agreed it could potentially be annoying. As far as Android Q goes, we will continue to monitor the behavior on various devices as development continues.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

After more discussion in triage we are going to keep this as P1 and look for an owner to investigate a workaround.
We could mitigate this by optimizing for the most popular android devices.
Chrome doesn't have the issue so we should be able to come up with something here.

Comment 13

[Vlad Baicu]

Attachment: Bug 1527666 - Handle long back press manually only on Android N.r=petru

On versions >= N all long back presses we're handled manually in onKeyDown
and onKeyUp which could lead to certain complications. I have changed it
only for Android N where onKeyLongPress does not trigger as it should.

Comment 14

[Vlad Baicu]

Possible regression of bug 1304688

@Andrei, can you test the fix and see if you can reproduce on Android Q anymore ?

Comment 15

[Andrei Bodea[:andrei]]

I was not able to reproduce this issue anymore on Google Pixel XL with Android Q using a build(with a possible fix) provided by @Vlad.
Note that I tried to reproduce this issue using YouTube, News and many other websites(I tapped at least 100 times on the back button) but the BACK button worked accordingly.

Comment 16

[Chris Peterson [:cpeterson]]

Does this back button bug affect GeckoView in Fenix? If so, would the Android N workaround need to be in GeckoView code or Fenix's app code?

It looks like this bug affects Fennec 67 Beta, so we'll want to uplift this fix to Beta.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da464aa8549f
Handle long back press manually only on Android N.r=petru

Comment 18

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/da464aa8549f

Comment 19

[Vlad Baicu]

(In reply to Chris Peterson [:cpeterson] from comment #16)

Does this back button bug affect GeckoView in Fenix? If so, would the Android N workaround need to be in GeckoView code or Fenix's app code?

It looks like this bug affects Fennec 67 Beta, so we'll want to uplift this fix to Beta.

As far as I can tell no, the onKeyLongPress event in Android N(api 24-25) does not trigger which means that we need to manually detect the long press event onKeyDown and onKeyUp if the user tapped the back button. In this case, the issue was on the frontend side.

Comment 20

[Pascal Chevrel:pascalc]

The next Fennec beta is beta 13 this Thursday, could you request an uplift today so as that we can have it uplifted by Monday on the beta branch? Thanks

Comment 21

[Vlad Baicu]

Comment on attachment 9059225 [details]
Bug 1527666 - Handle long back press manually only on Android N.r=petru

Beta/Release Uplift Approval Request

• User impact if declined: Users will continue to occasionally trigger the history list by tapping the back button.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow Andrei Bodea's STRs from bug 1527666
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor change, we're only manually handling the long back press on Android N where the event provided by the OS does not trigger as it should.
• String changes made/needed:

Comment 22

[Chris Peterson [:cpeterson]]

Clearing old needinfo for Stefan now that the fix has landed.

Comment 23

[Pascal Chevrel:pascalc]

Comment on attachment 9059225 [details]
Bug 1527666 - Handle long back press manually only on Android N.r=petru

Low-risk fix for a P1 Fennec regression, uplift approved for 67 beta 13, thanks.

Comment 24

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/05d12183776b

Comment 25

[Stefan Deiac]

I can confirm that this issue is fixed on the latest version of Nightly 68.0.1 (2019-04-20) using Samsung Galaxy S8 (Android 9) and Google Pixel (Android 9). I'll let the qa-triaged flag till it's verified on beta, thanks.

Comment 26

[Laurentiu Apahidean]

Hello,

I was not able to reproduce this issue anymore on Beta 67.0b13 using a Google Pixel XL with Android Q.

I went through a lot o popular website and used the back button many times and have not encountered the issue.

Due to my findings, I'll mark this issue as verified in Firefox 67.