1527702 - Use rotation on stories in discovery stream

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Right now we need to figure out what's involved in turning this on.

It's what release does to handle octr.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4790

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4799

Comment 3

[Ed Lee :Mardak]

QA steps:

1. about:config and reset browser.newtabpage.activity-stream.discoverystream.rec.impressions so it's {}
   (from a clean profile, the default browser.newtabpage.activity-stream.discoverystream.config with basic is fine)
2. open a new tab and note what's the first 2 stories shown
3. check that the pref from step 1 is no longer just {} and is probably something like {"31647":1550280066605,"33861":1550280066607,"33863":1550280066606}
4. change clock to be 2 hours later
5. restart firefox
6. initial home page probably is still showing the same stories (as it'll show cached stories while fetching the new ones)
7. refresh the page and at least 2 new stories should be shown
8. similar to checking the pref in step 3 but there's more entries

Might be good to copy/paste the values from step 3 and 8 to report back

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1527702 - Rotate based on impressions for recs

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4800

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/1cfd69d05aa1

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (67.0a1 Build ID - 20190217214556) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, new Pocket Stories are displayed after moving the system's time 2 hours in the future.

Also, in my case, the "browser.newtabpage.activity-stream.discoverystream.rec.impressions" pref's value was changed from the initial "{}" to "{"31647":1550486448814,"33978":1550486448816,"33987":1550486448817}" at step 3 and "{"31647":1550493717221,"33950":1550493717214,"33978":1550486448816,"33985":1550493717222,"33987":1550486448817}" at step 8.

Comment 8

[Andrei Oprea [:andreio]]

Comment on attachment 9044382 [details]
Bug 1527702 - Rotate based on impressions for recs

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1512725

User impact if declined

User experience is affected

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

Already tested

List of other uplifts needed

Bug 1522832

Risk to taking this patch

Medium

Why is the change risky/not risky? (and alternatives if risky)

Patch is in Nightly and has been tested

String changes made/needed

Comment 9

[Ed Lee :Mardak]

Bug 1528494 is a 67-only regression that would fail on 67 beta, so we have a fix incoming. We don't need the fix for 66 uplift, so attachment 9044382 [details] is still good.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9044382 [details]
Bug 1527702 - Rotate based on impressions for recs

OK for uplift for beta 10.

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/77f97b1778eb

Comment 12

[Ed Lee :Mardak]

(In reply to Marius Coman [:mcoman], Experiments QA from comment #7)

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (67.0a1 Build ID - 20190217214556)

Could you please verify this issue on an early 66.0b10 build:

Windows 64: https://queue.taskcluster.net/v1/task/enVix5uvRveeQnNfxxl5mQ/runs/0/artifacts/public/build/target.zip
OS X: https://queue.taskcluster.net/v1/task/BbyPjtloRuCbHM2gX_9Hlw/runs/0/artifacts/public/build/target.dmg
Linux 64: https://queue.taskcluster.net/v1/task/CTU-aOfCSZe2B2tBVk_1GQ/runs/0/artifacts/public/build/target.tar.bz2

Treeherder: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&searchStr=64-n%2C%28n%29&revision=c5b7791033e051902646cf52f0bfd6946c5a1704

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Beta (66.0b10 Build ID - 20190219202808) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, new Pocket Stories are displayed after moving the system's time 2 hours in the future.

Also, in my case, the "browser.newtabpage.activity-stream.discoverystream.rec.impressions" pref's value was changed from the initial "{}" to "{"31647":1550657788767,"34079":1550657788760,"34099":1550657788762}" at step 3 and "{"31647":1550665023250,"34054":1550665023245,"34079":1550657788760,"34090":1550665023246,"34099":1550657788762}" at step 8.

In order to verify this issue I've had to change the "browser.newtabpage.activity-stream.discoverystream.config" pref's value to "{"api_key_pref":"extensions.pocket.oAuthConsumerKey","enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic"}", because the feature is turned off by default in Beta.

Comment 14

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f98b2b564191