Closed Bug 1527702 Opened 5 years ago Closed 5 years ago

Use rotation on stories in discovery stream

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Iteration:
67.2 - Feb 11 - 24
Tracking Status
firefox66 + verified
firefox67 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

Details

(Keywords: github-merged)

Attachments

(4 files)

Right now we need to figure out what's involved in turning this on.

It's what release does to handle octr.

Assignee: nobody → sdowne
Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P1
Blocks: 1528410
User Story: (updated)

QA steps:

  1. about:config and reset browser.newtabpage.activity-stream.discoverystream.rec.impressions so it's {}
    (from a clean profile, the default browser.newtabpage.activity-stream.discoverystream.config with basic is fine)
  2. open a new tab and note what's the first 2 stories shown
  3. check that the pref from step 1 is no longer just {} and is probably something like {"31647":1550280066605,"33861":1550280066607,"33863":1550280066606}
  4. change clock to be 2 hours later
  5. restart firefox
  6. initial home page probably is still showing the same stories (as it'll show cached stories while fetching the new ones)
  7. refresh the page and at least 2 new stories should be shown
  8. similar to checking the pref in step 3 but there's more entries

Might be good to copy/paste the values from step 3 and 8 to report back

User Story: (updated)
Status: NEW → RESOLVED
Iteration: 67.1 - Jan 28 - Feb 10 → 67.2 - Feb 11 - 24
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (67.0a1 Build ID - 20190217214556) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, new Pocket Stories are displayed after moving the system's time 2 hours in the future.

Also, in my case, the "browser.newtabpage.activity-stream.discoverystream.rec.impressions" pref's value was changed from the initial "{}" to "{"31647":1550486448814,"33978":1550486448816,"33987":1550486448817}" at step 3 and "{"31647":1550493717221,"33950":1550493717214,"33978":1550486448816,"33985":1550493717222,"33987":1550486448817}" at step 8.

Status: RESOLVED → VERIFIED

Comment on attachment 9044382 [details]
Bug 1527702 - Rotate based on impressions for recs

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1512725

User impact if declined

User experience is affected

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

Already tested

List of other uplifts needed

Bug 1522832

Risk to taking this patch

Medium

Why is the change risky/not risky? (and alternatives if risky)

Patch is in Nightly and has been tested

String changes made/needed

Attachment #9044382 - Flags: approval-mozilla-beta?

Bug 1528494 is a 67-only regression that would fail on 67 beta, so we have a fix incoming. We don't need the fix for 66 uplift, so attachment 9044382 [details] is still good.

Comment on attachment 9044382 [details]
Bug 1527702 - Rotate based on impressions for recs

OK for uplift for beta 10.

Attachment #9044382 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(marius.coman)

I have verified this issue with the latest Firefox Beta (66.0b10 Build ID - 20190219202808) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, new Pocket Stories are displayed after moving the system's time 2 hours in the future.

Also, in my case, the "browser.newtabpage.activity-stream.discoverystream.rec.impressions" pref's value was changed from the initial "{}" to "{"31647":1550657788767,"34079":1550657788760,"34099":1550657788762}" at step 3 and "{"31647":1550665023250,"34054":1550665023245,"34079":1550657788760,"34090":1550665023246,"34099":1550657788762}" at step 8.

In order to verify this issue I've had to change the "browser.newtabpage.activity-stream.discoverystream.config" pref's value to "{"api_key_pref":"extensions.pocket.oAuthConsumerKey","enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic"}", because the feature is turned off by default in Beta.

Flags: needinfo?(marius.coman)
Blocks: 1529755
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: