Firefox inserts space after search engine keyword in quantum bar

RESOLVED FIXED in Firefox 67

Status

()

defect
P1
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: soeren.hentzschel, Assigned: dao)

Tracking

(Blocks 1 bug, {regression})

unspecified
Firefox 67
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 unaffected, firefox67 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Reporter

Description

4 months ago

STR:

  1. open the search engine settings and set a keyword for one of your search engines, for example "g" for google.com
  2. make sure browser.urlbar.quantumbar is enabled
  3. try to type something with the letter "g" in the address bar, for example "google"

Expected:

You can type "google" in the address bar without any problems.

Actual:

After typing "g" Firefox inserts a space after the "g". You can't remove the space. When you try to remove the space with the backspace key Firefox inserts a new space after the "g".

It doesn't happen with browser.urlbar.quantumbar disabled.

I just checked and it seems bug 1525269 caused this. At a glance I think in onQueryResults we're now setting the input text when we weren't before.

I've seen a related issue with paste - paste something in the urlbar and it ends up blank but with suggestions shown.

Dao, could you take a look please?

Blocks: 1525269
Flags: needinfo?(dao+bmo)
Keywords: regression
Priority: -- → P1
Whiteboard: [fxsearch]
Assignee

Updated

4 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)

Comment 3

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88bef42d564f
Let the preselected result not modify the urlbar value. r=Standard8

Comment 4

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.