1527724 - Firefox inserts space after search engine keyword in quantum bar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Sören Hentzschel]

STR:

1. open the search engine settings and set a keyword for one of your search engines, for example "g" for google.com
2. make sure browser.urlbar.quantumbar is enabled
3. try to type something with the letter "g" in the address bar, for example "google"

Expected:

You can type "google" in the address bar without any problems.

Actual:

After typing "g" Firefox inserts a space after the "g". You can't remove the space. When you try to remove the space with the backspace key Firefox inserts a new space after the "g".

It doesn't happen with browser.urlbar.quantumbar disabled.

Comment 1

[Mark Banner (:standard8)]

I just checked and it seems bug 1525269 caused this. At a glance I think in onQueryResults we're now setting the input text when we weren't before.

I've seen a related issue with paste - paste something in the urlbar and it ends up blank but with suggestions shown.

Dao, could you take a look please?

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1527724 - Let the preselected result not modify the urlbar value. r=Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88bef42d564f
Let the preselected result not modify the urlbar value. r=Standard8

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/88bef42d564f