Remove post element added traversal from XULDocument

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: bdahl, Assigned: bdahl)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago

Before when we had overlays, AddSubtreeToDocument and AddElementToDocumentPost use to do a lot more. They currently only handle some l10n code could be handled differently.

My plan is move all xul link elements to be <html:link> elements so their binding code gets handled in BindToTree instead. Then nsXULElement to handle the closing of a linkset element.

This clean up will help support some of browser.xhtml work. Eventually, linkset should also go away when we move more xul docs to have an html structure and use the <head> element.

(Assignee)

Updated

2 months ago
(Assignee)

Comment 1

2 months ago

Move functionality out of XULDocument::AddElementToDocumentPost:

  1. Convert all XUL link elements into HTML link elements which have
    code to handle when they are added to the DOM.
  2. Move handling of the end of a linkset element into nsXULElement's DoneAddingChildren callback.
  3. Move document direction reset to where the root element is created.
Blocks: 1527977

Comment 2

2 months ago
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/653381afe8bc
Remove special XUL DOM tree traversal. r=smaug

Comment 3

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.