Closed Bug 1527737 Opened 6 years ago Closed 6 years ago

Create some simple tests for the mainthreadio feature

Categories

(Core :: Gecko Profiler, enhancement, P2)

Product:
Core
Component:
Gecko Profiler
Version:
62 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1527737 - Add tests for main thread io in the profiler; r=julienw
47 bytes, text/x-phabricator-request
Details | Review

Currently we have no tests around turning on mainthreadio, and seeing if it correctly creates a payload. A first step is to make a simple test to turn it on, and verify that a payload exists.

Blocks: 1527023
Priority: -- → P2

I wrote a test, and it is currently failing on a debug build as it is hitting an assertion.

Assertion failure: curThreadData, at gecko/xpcom/build/IOInterposer.cpp:505
Depends on: 1529125
Attachment #9045083 - Attachment description: Bug 1527737 - Add tests for main thread io in the profiler → Bug 1527737 - Add tests for main thread io in the profiler; r?gerald
Attachment #9045083 - Attachment description: Bug 1527737 - Add tests for main thread io in the profiler; r?gerald → Bug 1527737 - Add tests for main thread io in the profiler; r?julienw
Attachment #9045083 - Attachment description: Bug 1527737 - Add tests for main thread io in the profiler; r?julienw → Bug 1527737 - Add tests for main thread io in the profiler; r=julienw

(In reply to Greg Tatum [:gregtatum] from comment #4)

https://treeherder.mozilla.org/#/
jobs?repo=try&revision=2f085c82108eeed30e626e99fd3b0df9b76f9cc0

My patch in bug 1531798 will fix the deadlock on Windows 7, and I think Windows 10 opt too.
Once that lands, the only obvious remaining failure will be on Windows 10 x64 debug, which is discussed in bug 1529125. It would be fine to disable the test on win 64 dbg for now.

Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cdd6695cfad8 Add tests for main thread io in the profiler; r=julienw

https://hg.mozilla.org/mozilla-central/rev/cdd6695cfad8

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → gtatum
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: