1527743 - Add a checkbox in prefs to toggle extensions.formautofill.reauth.enabled

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P2)

Description

[Matthew N. [:MattN]]

Attachment: OS authentication prefs checkbox design

This is a Legal blocker to shipping credit card storage (e.g. for credit card autofill or web payments).

This probably needs help from a copywriter still.

Comment 1

[Matthew N. [:MattN]]

We also need to fix the code to honour this pref for the credit card autofill case. Currently it's only honoured for the edit card page.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1527743 - Add a checkbox in prefs to toggle extensions.formautofill.reauth.enabled. r?abr

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Cindy, Holly - can I ask for the copy for the UI? I have the code ready using the mock text from the design.

Comment 4

[[e-mail]]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #3)

Cindy, Holly - can I ask for the copy for the UI? I have the code ready using the mock text from the design.

I've written some copy to accompany the checkbox and it's out for review by the Content Strategy team - will post here when it's been approved.

Comment 5

[[e-mail]]

UX rec: New checkbox should be indented under the credit card checkbox line. String below:

Forms and Autofill  
[   ] Autofill addresses   Learn more   {Saved Addresses…}
[   ] Autofill credit cards  Learn more   {Saved Credit Cards…}
         [   ] Ask for permission (with TouchID or your device’s password) to autofill, view, or edit stored credit cards.

Comment 6

[Matthew N. [:MattN]]

     [   ] Ask for permission (with TouchID or your device’s password) to autofill, view, or edit stored credit cards.

That string seems very macOS-specific. Should we replace "TouchID" with "Windows Hello" on Windows?

I guess for now we need to hide this option on Linux too and anywhere else OSKeyStore.canReauth() returns false (including old macOS)

Comment 7

[[e-mail]]

Good catch! Thank you

New UX rec:
Display logic:
OSKeyStore.canReauth() returns false: Do not display
OSKeyStore.canReauth() returns true: New checkbox should be displayed indented under the credit card checkbox line. Hierarchy & string below:

Forms and Autofill  
[   ] Autofill addresses   Learn more   {Saved Addresses…}
[   ] Autofill credit cards  Learn more   {Saved Credit Cards…}
         [   ] Require [OS type] authentication to autofill, view, or edit stored credit cards.

Strings:
MacOS: Require macOS authentication to autofill, view, or edit stored credit cards.
Windows : Require Windows authentication to autofill, view, or edit stored credit cards.

Comment 8

[[e-mail]]

Passed legal review.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f9e8c915af4
Add a checkbox in prefs to toggle extensions.formautofill.reauth.enabled. r=abr,flod,MattN

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9f9e8c915af4

Comment 11

[Francesco Lodolo [:flod]]

Question I've got from a localizer:

• The checkbox label (Require XXX authentication to autofill…) ends up with a period, which seems incorrect for a checkbox.
• The mockup linked in comment 0 has a "Learn more" link after the checkbox, but that's not in the code.

Should the period be removed, or there's a plan to add a link?

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

That's a question for Holly. The copy was introduced in Comment 7.

Comment 13

[[e-mail]]

Looking into an answer for this (it's dependent on SUMO).

Comment 14

[[e-mail]]

Please keep the period at the end of the sentence and add a "Learn more" link to the end of it (as shown in the comp).
Link url: https://support.mozilla.org/en-US/kb/credit-card-autofill#w_require-authentication-for-autofill

Comment 15

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed on Beta 79.0b7 on MacOS 10.13, Windows 10 and Ubuntu 18.04.
"Require macOS/Windows authentication to autofill, view, or edit stored credit cards." checkbox is displayed.
On latest Nightly 80.0a1 (2020-07-13) the "Learn more" hyperlink is also displayed at the end of the above mentioned string. On Ubuntu 18.04 the checkbox is not displayed.