Decouple folder creation from RDF
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
People
(Reporter: benc, Assigned: benc)
References
Details
Attachments
(1 file, 1 obsolete file)
8.16 KB,
patch
|
benc
:
review+
|
Details | Diff | Splinter Review |
Folders are currently constructed by looking up the correct nsIFactory
and calling createInstance()
.
The factories all have the form"@mozilla.org/rdf/resource-factory;1?name=" + scheme
, which kind of implies they're registered as part of the RDF system.
They need to be freed from any RDF entanglements.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
My patch(es) for Bug 1527764 will move the folder creation into the folder-lookup-service, so easiest to wait until that stuff lands before worrying about this one.
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
This patch builds on top of the two RDF-removal patches in Bug 1527764.
It just shuffles about some naming to get folder creation out of the RDF code.
Comment on attachment 9055367 [details] [diff] [review] decouple-folder-creation-from-rdf-1.patch Review of attachment 9055367 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks. ::: mailnews/base/src/folderLookupService.js @@ +66,5 @@ > > // Check that uri has an active scheme, in case this folder is from > // an extension that is currently disabled or hasn't started up yet. > let scheme = uri.match(/\w*/)[0]; > + let contractID = "@mozilla.org/mail/folder-factory;1?name=" + scheme; Declare it const while there. ::: mailnews/base/util/nsMsgDBFolder.h @@ -8,5 @@ > > #include "mozilla/Attributes.h" > #include "msgCore.h" > #include "nsIMsgFolder.h" > -#include "nsRDFResource.h" Great, last include ;)
Updated•1 year ago
|
Comment 4•1 year ago
|
||
So this is waiting for bug 1527764 which is waiting for bug 1534163 which is ready now, right? So how about rebasing everything as necessary and doing a final try run?
Assignee | ||
Comment 5•1 year ago
|
||
Rebased.
To apply on top of the two patches in Bug 1527764.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3970c1407633
Move folder-factory lookup out of RDF. r=aceman
Updated•1 year ago
|
Description
•