Closed Bug 1527821 Opened 6 years ago Closed 6 years ago

27.43 - 28.04% tp5n nonmain_startup_fileio (windows7-32) regression on push fd700b0b82a63321ff56bf63228f43ad4316cd9b (Fri Feb 8 2019)

Categories

(Toolkit :: Add-ons Manager, defect)

All
Windows
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: igoldan, Unassigned)

References

Details

(Keywords: perf, regression, talos-regression)

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=fd700b0b82a63321ff56bf63228f43ad4316cd9b

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

28% tp5n nonmain_startup_fileio windows7-32 opt e10s stylo 2,004,354.75 -> 2,566,358.75
27% tp5n nonmain_startup_fileio windows7-32 pgo e10s stylo 2,004,016.33 -> 2,553,645.83

Improvements:

5% sessionrestore_no_auto_restore windows7-32 pgo e10s stylo 338.92 -> 321.92
4% sessionrestore_no_auto_restore windows7-32 opt e10s stylo 348.08 -> 334.92

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=19239

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Component: General → Add-ons Manager
Product: Testing → Toolkit
Flags: needinfo?(gijskruitbosch+bugs)

There are also tp5n non_main_startup_fileio regressions on Windows 10 (but because of some random outliers, Perfherder falsely treats them as improvements).

This is expected and desirable. Having the preload cache available at startup means that we read its data on a background thread at startup, which is what we want. But, in any case, this is largely a test-only change, since most users don't install add-ons in most of their sessions. Talos just has behavior which is closer to most non-automation sessions now.

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.