Closed Bug 1527980 Opened 6 years ago Closed 6 years ago

Add devtools for resetting and picking a layout variant

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 67
Iteration:
67.1 - Jan 28 - Feb 10
Tracking Flags:
Tracking Status
firefox67 --- verified

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

(Keywords: github-merged)

User Story

QA steps to verify

Testing enabled / opt-out:
1. Turn on new tab devtools: Set `browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` to `true`.
2. Navigate to about:newtab#devtools-ds
3. Make sure the enabled checkbox is checked. Ensure discovery stream is visible on another tab.
4. Go to about:preferences#home and click the "Turn off discovery stream" button.
5. On about:newtab#devtools-ds, ensure that the enabled checkbox is now unchecked and you see the message "(Note: User has opted-out. Check this box to reset)" next to the checkbox.
6. Check the enabled box. Ensure that discovery stream now shows up again on a new tab page and the opt-out message has disappeared next to the checkbox.

Testing layout variants.
1. On about:newtab#devtools-ds, ensure discovery stream is enabled.
2. Check the "basic" radio box. Ensure you see a 3-card layout on new tab.
3. Check the "dev-test-all" radio box. Ensure you see a long layout with many elements.
4. On about:config, try changing the `browser.newtabpage.activity-stream.discoverystream.config` pref to include `layout_variant=basic` in the endpoint.
5. Check that on about:newtab#devtools-ds the basic radio checkbox is now checked.

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4792
52 bytes, text/x-github-pull-request
Details | Review

There has been some confusion about the opt-out pref and changing the pref in general. These tools will make it easier to test Discovery Stream from the devtools ui at about:newtab#devtools-ds.

Iteration: --- → 67.1 - Jan 28 - Feb 10

Fyi, clicking "enable" from devtools cancels opt out.

User Story: (updated)
User Story: (updated)
User Story: (updated)

Not critical for uplift, although it would be nice for QA to be able to test more easily...

Keywords: github-merged

Would you mind verifying this / trying this out when it makes it to nightly?

Flags: needinfo?(bnagabandi)
Blocks: 1528119
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

QA Results:

Tested on :

FF Nightly version : 67.0a1 (2019-02-20)
OS : Mac and Windows 10 Pro

Works as expected.

Closing as verified.

Flags: needinfo?(bnagabandi)
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: