Closed
Bug 1528050
Opened 6 years ago
Closed 6 years ago
make nsStyle{List,Position}::CalcDifference old style struct argument non-nullable
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
The aOldDisplay and aOldStyleVisibility arguments passed in to nsStyleList::CalcDifference and nsStylePosition::CalcDifference are never null, so we should change them to be a reference (like their aNewData arguments) and remove the null checks of them.
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c9f0c796287
Remove null checks of nsStyle{List,Position}::CalcDifference extra args. r=emilio
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → cam
You need to log in
before you can comment on or make changes to this bug.
Description
•