1528074 - Cleanup MSVC warning flags for clang-cl

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

See https://phabricator.services.mozilla.com/D19615?id=61489#inline-107248

Comment 1

[(Away)]

Attachment: Clean up some media warning flags

I suspect these may have been cargo-culted from elsewhere.

We only need -Wno-sign-compare, which we can add regardless of compiler because clang-cl understands it natively in addition to the -wdNNNN form.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0b1558a0b84
Clean up some media warning flags r=jya

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b0b1558a0b84

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b0b1558a0b84

Comment 5

[(Away)]

Attachment: Translate MSVC warning flags to clang spelling where supported

clang-cl only acts on five MSVC warning flags: https://github.com/llvm/llvm-project/blob/7219c7e9af7718f026ac5e3ea72249d037898e5b/clang/include/clang/Driver/CLCompatOptions.td#L188-L197

With MSVC now unsupported, most -wdNNNN have no effect and can be removed.

This patch converts the five supported warnings to their clang spellings, as preparation for a subsequent patch that will remove all remaining [/-]w[edo][0-9]{4}.

Comment 6

[(Away)]

Attachment: Remove MSVC warning flags that clang-cl doesn't understand

Per the previous patch, clang-cl only understands five MSVC-style warning flags: https://github.com/llvm/llvm-project/blob/7219c7e9af7718f026ac5e3ea72249d037898e5b/clang/include/clang/Driver/CLCompatOptions.td#L188-L197

This patch removes the flags that clang-cl doesn't understand.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88c9c5b8d99c
Translate MSVC warning flags to clang spelling where supported r=froydnj

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/88c9c5b8d99c

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04b7ccd07ab8
Remove MSVC warning flags that clang-cl doesn't understand r=chmanchester

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/04b7ccd07ab8