Cleanup MSVC warning flags for clang-cl

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: glandium, Assigned: dmajor)

Tracking

(Depends on 1 bug)

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Updated

3 months ago
Assignee: nobody → dmajor
(Assignee)

Updated

3 months ago
Keywords: leave-open
(Assignee)

Comment 1

3 months ago

I suspect these may have been cargo-culted from elsewhere.

We only need -Wno-sign-compare, which we can add regardless of compiler because clang-cl understands it natively in addition to the -wdNNNN form.

(Assignee)

Updated

3 months ago
Depends on: 1529949

Comment 2

3 months ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0b1558a0b84
Clean up some media warning flags r=jya
(Assignee)

Comment 5

2 months ago

clang-cl only acts on five MSVC warning flags: https://github.com/llvm/llvm-project/blob/7219c7e9af7718f026ac5e3ea72249d037898e5b/clang/include/clang/Driver/CLCompatOptions.td#L188-L197

With MSVC now unsupported, most -wdNNNN have no effect and can be removed.

This patch converts the five supported warnings to their clang spellings, as preparation for a subsequent patch that will remove all remaining [/-]w[edo][0-9]{4}.

(Assignee)

Comment 6

2 months ago

Per the previous patch, clang-cl only understands five MSVC-style warning flags: https://github.com/llvm/llvm-project/blob/7219c7e9af7718f026ac5e3ea72249d037898e5b/clang/include/clang/Driver/CLCompatOptions.td#L188-L197

This patch removes the flags that clang-cl doesn't understand.

Comment 7

2 months ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88c9c5b8d99c
Translate MSVC warning flags to clang spelling where supported r=froydnj
(Assignee)

Updated

2 months ago

Comment 9

2 months ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04b7ccd07ab8
Remove MSVC warning flags that clang-cl doesn't understand r=chmanchester

Comment 10

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.