Closed Bug 1528150 Opened 6 years ago Closed 6 years ago

Categories

(Firefox Build System :: Toolchains, enhancement)

enhancement
Not set
normal

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

gn has moved to a standalone repository, which would save some serious time building gn, since it's currently dominated by cloning 3 git repositories, one of which is absolutely massive.

Make some adjustments to make the build work:

  • On Linux, a newer GCC is needed, and -lrt is missing for
    clock_gettime.
  • On Mac, ninja expect AR be accept ar arguments, which clang doesn't,
    so use llvm-ar.
  • On Windows, remove the /WX flag that upstream sets (warnings as
    errors) because there are warnings in the code, and remove the
    explicit /MACHINE:x64 linker flag because we're building for x86.
    (we could build for x64, but I'd rather leave that to a followup)

With this, bug 1528155 and bug 1527798, gn tasks on all platforms (!) finish in 3 minutes, instead of 20 for Linux and Mac and > 30 for Windows.

(In reply to Mike Hommey [:glandium] from comment #0)

gn has moved to a standalone repository, which would save some serious time
building gn, since it's currently dominated by cloning 3 git repositories,
one of which is absolutely massive.

Not to mention that the revision we build is so old that it can't be used for LLVM's gn build. Thanks for doing this.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: