Closed
Bug 1528226
Opened 6 years ago
Closed 6 years ago
rustc version should be checked before that of cbindgen
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: mak, Assigned: glandium)
Details
Attachments
(1 file)
Today I ran "cargo install cbingden --force" because the build was complaining about a too old version of it.
After that cbindgen just stopped working, doing nothing in the shell.
I downgraded cbindgen from 0.8.0 to 0.7.1, that allowed the build to continue, but it stopped one second after stating rustc was too old.
Long story short, we suggest to update cbindgen before checking the rustc version, that may end up building cbindgen with an old rustc version, generating a broken cbindgen.
We should maybe check the rustc version before checking (or before suggesting to upgrade) cbindgen.
|
Assignee | |
Comment 1•6 years ago
|
||
Please file a cbindgen issue wrt its brokenness with older rustc.
Assignee: nobody → mh+mozilla
Summary: cbindgen may broke if built with an old rustc version → rustc version should be checked before that of cbindgen
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/4befc5c89e69
Check rustc version before cbindgen. r=froydnj
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•