1528260 - Clarify and implement metric expiry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Michael Droettboom [:mdroettboom]]

This current version of the glean spec says:

Expiry

Every metric definition will need to specify if and when it expires. This means that one of the following properties must be set:

• disabled: (bool, optional) A boolean value specifying whether or not a metric is disabled. Metrics with this property set to True will silently ignore any collection performed on them.

• expires_after_build_date: (date/string, optional) If provided, an ISO 8601 date that represents the day from which any collection using the metric should be silently ignored. The date is checked at build time. If the specified date is passed, this metric is seen as expired.

First, there seems to be a contradiction here -- if one of these must be specified, there is no way to specify that we expect a metric to be permanent. It might be a good idea (as :liuche suggested in the data review of 1499761) that we require that to be explicit.

Secondly, these features need to be implemented, and this bug can serve to track that.

Comment 1

[Chenxia Liu [:liuche]]

I'm also fine with every probe having expiry by default :) This means the framework forces users to set an expiry date/version.
However, that means that there should be documentation about what approval process is needed to make a probe expiry "never". This should be limited to things like baseline telemetry, and should be a rare case for other telemetry.

Comment 2

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request

Comment 3

[Michael Droettboom [:mdroettboom]]

Attachment: Proposal

Comment 4

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6551b1a78064
[components] 1528260: Make expires mandatory