1528296 - Remove shared modules from the shader editor, audio editor, and canvas.

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Yulia Startsev [:yulia]]

There are a number of shared modules that should be removed as part of the panel deprecation.

Two come to mind right away

• CallWatcher
• Deprecation Notice

There may be more.

Comment 1

[Tim Nguyen :ntim]

There's also the SideMenuWidget, which I think is exclusively used in those panels.

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove SideMenuWidget and dependancies;

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove eslint empty file requirements for old panels;

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove call watcher (and references to removed panels in the debugger including the gcli);

Comment 5

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove unused viewer-helpers;

Comment 6

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove unused function call

Comment 7

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove deprecation message

Comment 8

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove comma; r=jlast

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d321819c273
remove SideMenuWidget and dependancies; r=vporof
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e055733ee57
remove eslint empty file requirements for old panels; r=vporof
https://hg.mozilla.org/integration/mozilla-inbound/rev/78be67cfabe8
remove call watcher (and references to removed panels in the debugger including the r=vporof
https://hg.mozilla.org/integration/mozilla-inbound/rev/cebff9f6f811
remove unused viewer-helpers; r=vporof
https://hg.mozilla.org/integration/mozilla-inbound/rev/47fff0f9b424
remove unused function call r=vporof
https://hg.mozilla.org/integration/mozilla-inbound/rev/285c56c29146
remove deprecation message r=vporof
https://hg.mozilla.org/integration/mozilla-inbound/rev/eee6b5f77d67
remove comma; r=jlast

Comment 10

[Yulia Startsev [:yulia]]

Attachment: Bug 1528296 - remove browser-chrome-gpu tests; r=vporof

the Canavas debugger tests appear to be the last tests using browser-chrome-gpu. This patch
removes those tests from being run on try.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864974f824cf
remove SideMenuWidget and dependancies; r=vporof
https://hg.mozilla.org/integration/autoland/rev/aaef9f2c3b39
remove eslint empty file requirements for old panels; r=vporof
https://hg.mozilla.org/integration/autoland/rev/a45827002884
remove call watcher (and references to removed panels in the debugger including the r=vporof
https://hg.mozilla.org/integration/autoland/rev/b7cc6eee1f24
remove unused viewer-helpers; r=vporof
https://hg.mozilla.org/integration/autoland/rev/f87bb852e074
remove unused function call r=vporof
https://hg.mozilla.org/integration/autoland/rev/be6699d71bec
remove deprecation message r=vporof
https://hg.mozilla.org/integration/autoland/rev/4922ae983a56
remove comma; r=jlast
https://hg.mozilla.org/integration/autoland/rev/e2d0e392fb62
remove browser-chrome-gpu tests; r=vporof

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/864974f824cf
https://hg.mozilla.org/mozilla-central/rev/aaef9f2c3b39
https://hg.mozilla.org/mozilla-central/rev/a45827002884
https://hg.mozilla.org/mozilla-central/rev/b7cc6eee1f24
https://hg.mozilla.org/mozilla-central/rev/f87bb852e074
https://hg.mozilla.org/mozilla-central/rev/be6699d71bec
https://hg.mozilla.org/mozilla-central/rev/4922ae983a56
https://hg.mozilla.org/mozilla-central/rev/e2d0e392fb62