Remove shared modules from the shader editor, audio editor, and canvas.
Categories
(DevTools :: General, enhancement, P3)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: ystartsev, Assigned: ystartsev)
References
Details
Attachments
(8 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
There are a number of shared modules that should be removed as part of the panel deprecation.
Two come to mind right away
- CallWatcher
- Deprecation Notice
There may be more.
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
There's also the SideMenuWidget, which I think is exclusively used in those panels.
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
|
|
Assignee | |
Comment 6•2 years ago
|
||
|
|
Assignee | |
Comment 7•2 years ago
|
||
|
|
Assignee | |
Comment 8•2 years ago
|
||
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d321819c273 remove SideMenuWidget and dependancies; r=vporof https://hg.mozilla.org/integration/mozilla-inbound/rev/3e055733ee57 remove eslint empty file requirements for old panels; r=vporof https://hg.mozilla.org/integration/mozilla-inbound/rev/78be67cfabe8 remove call watcher (and references to removed panels in the debugger including the r=vporof https://hg.mozilla.org/integration/mozilla-inbound/rev/cebff9f6f811 remove unused viewer-helpers; r=vporof https://hg.mozilla.org/integration/mozilla-inbound/rev/47fff0f9b424 remove unused function call r=vporof https://hg.mozilla.org/integration/mozilla-inbound/rev/285c56c29146 remove deprecation message r=vporof https://hg.mozilla.org/integration/mozilla-inbound/rev/eee6b5f77d67 remove comma; r=jlast
|
|
Assignee | |
Comment 10•2 years ago
|
||
the Canavas debugger tests appear to be the last tests using browser-chrome-gpu. This patch
removes those tests from being run on try.
|
||
Comment 11•2 years ago
|
||
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/864974f824cf remove SideMenuWidget and dependancies; r=vporof https://hg.mozilla.org/integration/autoland/rev/aaef9f2c3b39 remove eslint empty file requirements for old panels; r=vporof https://hg.mozilla.org/integration/autoland/rev/a45827002884 remove call watcher (and references to removed panels in the debugger including the r=vporof https://hg.mozilla.org/integration/autoland/rev/b7cc6eee1f24 remove unused viewer-helpers; r=vporof https://hg.mozilla.org/integration/autoland/rev/f87bb852e074 remove unused function call r=vporof https://hg.mozilla.org/integration/autoland/rev/be6699d71bec remove deprecation message r=vporof https://hg.mozilla.org/integration/autoland/rev/4922ae983a56 remove comma; r=jlast https://hg.mozilla.org/integration/autoland/rev/e2d0e392fb62 remove browser-chrome-gpu tests; r=vporof
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/864974f824cf
https://hg.mozilla.org/mozilla-central/rev/aaef9f2c3b39
https://hg.mozilla.org/mozilla-central/rev/a45827002884
https://hg.mozilla.org/mozilla-central/rev/b7cc6eee1f24
https://hg.mozilla.org/mozilla-central/rev/f87bb852e074
https://hg.mozilla.org/mozilla-central/rev/be6699d71bec
https://hg.mozilla.org/mozilla-central/rev/4922ae983a56
https://hg.mozilla.org/mozilla-central/rev/e2d0e392fb62
Description
•