Closed Bug 1528299 Opened 5 years ago Closed 5 years ago

InspectorUtils.getCSSStyleRules returns incorrect type

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jkratzer, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The InspectorUtils getCSSStyleRules IDL definition defines the wrong return type.

namespace InspectorUtils {
  // documentOnly tells whether user and UA sheets should get included.
  sequence<StyleSheet> getAllStyleSheets(Document document, optional boolean documentOnly = false);
  sequence<CSSRule> getCSSStyleRules(
    Element element,
    [TreatNullAs=EmptyString] optional DOMString pseudo = "");

This should return a sequence of CSSStyleRule objects.

See Also: → 1514960

WebIDL Bindings component is for bindings generation only. Moving this over to layout, which is where InspectorUtils specific bugs should go I think?

Component: DOM: Bindings (WebIDL) → Layout

Should be easy to just change the webidl file as well as the parameter of InspectorUtils::GetCSSStyleRules.

Yeah, I can just do that.

Assignee: nobody → emilio
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65ed1a6835b9
Make InspectorUtils.getCSStyleRules return a proper CSSStyleRule sequence. r=xidorn
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Blocks: domino
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: