1528299 - InspectorUtils.getCSSStyleRules returns incorrect type

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jason Kratzer [:jkratzer]]

The InspectorUtils getCSSStyleRules IDL definition defines the wrong return type.

namespace InspectorUtils {
  // documentOnly tells whether user and UA sheets should get included.
  sequence<StyleSheet> getAllStyleSheets(Document document, optional boolean documentOnly = false);
  sequence<CSSRule> getCSSStyleRules(
    Element element,
    [TreatNullAs=EmptyString] optional DOMString pseudo = "");

This should return a sequence of CSSStyleRule objects.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

WebIDL Bindings component is for bindings generation only. Moving this over to layout, which is where InspectorUtils specific bugs should go I think?

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Should be easy to just change the webidl file as well as the parameter of InspectorUtils::GetCSSStyleRules.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah, I can just do that.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1528299 - Make InspectorUtils.getCSStyleRules return a proper CSSStyleRule sequence. r=#style

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65ed1a6835b9
Make InspectorUtils.getCSStyleRules return a proper CSSStyleRule sequence. r=xidorn

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/65ed1a6835b9